search

Makin-Things / platinum-weather-card

This is a fully customisable weather card for Home Assistant with a graphical configuration.
MIT License
138 stars 33 forks source link

Card doesn't support new weather entitles without forecast attributes #101

Closed Scoop2389 closed 11 months ago

Scoop2389 commented 11 months ago

Checklist:

Release with the issue: Card Version: 1.0.5 Home Assistant Core: 2023.9

Last working release (if known): Card Version: 1.0.5 Home Assistant Core: 2023.8.4

Browser and Operating System: Windows, Edge, Chrome + Android, Home Assistant Mobile App

Description of problem: In Home Assistant Core 2023.9, a new weather forecast scheme was introduced in which entities no longer have forecast attributes, and instead forecast data must be retrieved by calling a service (weather.get_forecast) (Ref). This card does not call the service, and therefore entites without forecast attributes do not appear in this card.

Javascript errors shown in the web inspector (if applicable):

platinum-weather-card-df6d26e2.js:41  Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'filter')
    at ge._getForecastPropFromWeather (platinum-weather-card-df6d26e2.js:268:71)
    at ge._checkForErrors (platinum-weather-card-df6d26e2.js:73:17788)
    at ge.render (platinum-weather-card-df6d26e2.js:268:1014)
    at ge.update (platinum-weather-card-df6d26e2.js:47:547)
    at ge.performUpdate (platinum-weather-card-df6d26e2.js:41:5079)
    at ge.scheduleUpdate (platinum-weather-card-df6d26e2.js:41:4726)
    at ge._$EC (platinum-weather-card-df6d26e2.js:41:4634)
Scoop2389 commented 11 months ago

I am suggesting removal of if this card from HACS because it has not been maintained since 2022. You can vote and comment on it here: https://github.com/hacs/integration/issues/3290

Makin-Things commented 11 months ago

@Scoop2389 , considering it is open source software and you have not contributed or funded my work in any way whatsoever I really cant fathom how you think this behaviour in any way is appropriate. The HA guys randomly change things that break work done by individuals to try and make life better by filling the gaps. I am happy if it it gets removed from HACS because then I won't have to deal with ungrateful people like yourself. Bottom line, if you don't like it don't use it and stuff your whinging. Also you broke my number 1 rule. If you want any help , don't be a dick.

rudizl commented 11 months ago

@Scoop2389 , considering it is open source software and you have not contributed or funded my work in any way whatsoever I really cant fathom how you think this behaviour in any way is appropriate. The HA guys randomly change things that break work done by individuals to try and make life better by filling the gaps. I am happy if it it gets removed from HACS because then I won't have to deal with ungrateful people like yourself. Bottom line, if you don't like it don't use it and stuff your whinging. Also you broke my number 1 rule. If you want any help , don't be a dick.

@Makin-Things , do you have plans to update the card? I`m using PWS and this card is the only one that can show what I want :(

Scoop2389 commented 11 months ago

@Makin-Things I was not trying to be mean or aggressive in any way. I am trying to help users by 1. Reporting an issue 2. Reporting an unmaintained card to the HACS development team to prevent users from choosing a card with many issues that don't look like they will be resolved. The readme of your card even says that this repository is not maintained. Unmaintained cards should not be part of HACS default repositories. None of this is my fault, these are the rules. You can't prevent your repository from being removed just by attacking anyone who tries. You also have many open pull requests that it seems you have not reviewed (if I wanted to help, I couldn't). If you do wish to look over the pull requests and/or start maintaining the card again, I will happily close the HACS issue. If you don't wish to work on a card because a user did what they were supposed to in order to report a bug and report an unmaintained repository, then that's fine also.

Sudo-Rob commented 11 months ago

@Scoop2389,

This weather card still works for me, and could potentially work for you if you can generate entities from PWS (which, if I'm not mistaken, appears to be an unsupported integration). If you don't already use it, making sensor templates is a useful skill to learn. Moreover, there's a reasonable chance someone will come up with a template or another way to use this card before the transition to the new scheme occurs.

Removing this integration because it doesn't comply with your needs may be a disservice to others, not to mention its creator, or even yourself. Just because you can do something doesn't necessarily mean you should.

Just sayin'.

Respectfully.

Scoop2389 commented 11 months ago

This is the type of reasonable discussion that makes me want to contribute and help resolve an issue like this. Thank you.

If you don't mind me asking, what weather forecast integration do you use? I have been trying to find one that works with this card (or any other similar weather card), but I haven't yet.

Also, what do you think I should do about this issue? I don't want to make the author more mad, so I don't want to reopen it, but it is still an important bug that needs to be fixed.

(I closed the HACS request)

Sudo-Rob commented 11 months ago

This is not the venue for support.

Start here: https://community.home-assistant.io/t/platinum-weather-card-support/449166

DavidFW1960 commented 11 months ago

(I closed the HACS request)

I don't think you get how arrogant and disrespectful opening issues like this is and is perceived by the community.

Scoop2389 commented 11 months ago

I'm sorry, I wasn't ever trying to be mean or arrogant. I was trying to do the right thing to prevent people from having to deal with things that are broken.