[MLP-169] Service added along with unit test

MakingSense / WebApiCore-Seed

MIT License

2 stars 5 forks source link

[MLP-169] Service added along with unit test #2

Closed mdesagranja closed 7 years ago

mdesagranja commented 7 years ago

Background We had to add the first Service layer to the seed project, with a single method for querying the user

Changes done

Added the Domain project
- Added a User service class
- Added a Unit Test project for testing the new service

Approvers required @mvazquez-ms @AlphaGit

AlphaGit commented 7 years ago

+20,598 −3

I see something must be wrong. There are way too many changes here. From the list in GitHub I see there are lots of files that should not be here. I think this is the PR in which you'll want to add the gitignore file.

AlphaGit commented 7 years ago

@mdesagranja I think it might be easier if you don't add the gitignore file again. Doing that will generate conflicts with the original branch, and it will also show that you removed a bunch of files that are not supposed to be there in the first place (this means more conflicts).

Maybe you can just rebase this branch on top of the original one, given the gitignore that you added in it should already take care of the problem.

mdesagranja commented 7 years ago

Done with updates people!! Shall we recheck so I can merge? Thanks!!

andresmoschini commented 7 years ago

Nice!, thanks for your patience.

mdesagranja commented 7 years ago

I'm closing this as I merged it manually from the secondary branch to master and github won't notice