search

MakingSense / WebApiCore-Seed

MIT License
2 stars 5 forks source link

[WIP] Update ValuesController.cs #6

Closed alcabelu closed 6 years ago

alcabelu commented 6 years ago

Background

We need add functionality to the methods of controler Values Controler to interact with the database suggest move the using behind namespace ( recommended by stylecop https://stylecop.codeplex.com/)

Changes done

Add functionality ValuesControler class

Approvers required

@AlphaGit @mvazquez-ms

andresmoschini commented 6 years ago

suggest move the using behind namespace

I am not aware of the pros and cons of each approach, but in general, we tend to use the old one, and VS templates also. Is there a good reason to change that convention? Are there a significative quantity of Making Sense developers agree on that?

AlphaGit commented 6 years ago

@alcabelu @martinkeimel Guys, I don't think this PR was ready to merge as it is. I don't mind if we later go on to fix it, but please remember that this is a public framework that we maintain, and as such, we require a certain level of quality.

mravinale commented 6 years ago

@AlphaGit Agree with that, I think during the next week @martinkeimel can help with that, thanks you for taking care of our code :)