search

MakingSense / moment-datepicker

[ABANDONED REPOSITORY] The best bootstrap datepicker!
Apache License 2.0
92 stars 64 forks source link

Issue #67 scrolling placement error solved #68

Open joanvila opened 8 years ago

joanvila commented 8 years ago

This pull request soves a problem that happens when there is a scroll in the page. When this happens, the datepicker much more below than it should.

The problem appears in the screenshot attached.

screen shot 2016-03-16 at 18 28 55

andresmoschini commented 8 years ago

Thanks @joanvila, but previous code looks as a hack done to support a particular case, if we apply your fix we will probably break something else.

I will try to spend some time to research the possible problems.

joanvila commented 8 years ago

Thank you for the response @andresmoschini If I find something that breaks down with this solution I will tell it :)

infocynic commented 7 years ago

So it's been almost a year and a half... if nobody has found a reason to avoid adopting this fix, I suggest it be incorporated. Given that the demo page itself is broken, clearly there's a problem here, and this is an easy fix. It tests fine in Chrome, Firefox, IE 11, and Edge. If the previous fix was intended for a specific problem, it should have been documented, but as-is, it's just causing new problems, so should be removed.