search

Makman2 / CE3D

A terminal 3D engine
GNU General Public License v3.0
4 stars 0 forks source link

Codestyle improvements #143

Closed sils closed 10 years ago

sils commented 10 years ago

I have some other ideas. Some evil ones :) it may be that you wont be able to commit anything that contains trailing spaces in the future.

sils commented 10 years ago

ok, the hooks are non-committable. SO lets go for this solution so far.

Makman2 commented 10 years ago

Are you sure to put a script into our repo for removing trailing spaces? User's can do that on their own, maybe we share this script with github gist?

sils commented 10 years ago

whats github gist?

2014-08-05 16:36 GMT+02:00 Makman2 notifications@github.com:

Are you sure to put a script into our repo for removing trailing spaces? User's can do that on their own, maybe we share this script with github gist?

Reply to this email directly or view it on GitHub https://github.com/Makman2/CE3D/pull/143#issuecomment-51206090.

Makman2 commented 10 years ago

A script or snippet share thing from git. You can look at it when you click Gist at the top of this page.

sils commented 10 years ago

I just want no more patches (from you) with space errors, what can I do except providing such a script? ;)

2014-08-05 16:52 GMT+02:00 Makman2 notifications@github.com:

A script or snippet share thing from git. You can look at it when you click Gist at the top of this page.

Reply to this email directly or view it on GitHub https://github.com/Makman2/CE3D/pull/143#issuecomment-51208469.

sils commented 10 years ago

oh and by the way this script is basically a replacement for the coala make target in the future.

2014-08-05 16:57 GMT+02:00 Lasse Schuirmann lasse.schuirmann@gmail.com:

I just want no more patches (from you) with space errors, what can I do except providing such a script? ;)

2014-08-05 16:52 GMT+02:00 Makman2 notifications@github.com:

A script or snippet share thing from git. You can look at it when you

click Gist at the top of this page.

Reply to this email directly or view it on GitHub https://github.com/Makman2/CE3D/pull/143#issuecomment-51208469.

Makman2 commented 10 years ago

I already thought that... But I think we share this via gist, a file in our beautiful directory makes me sad :O

sils commented 10 years ago

do what you like. In case you dont want this commit you'd want to do: git checkout codestyle git rebase --interactive

remove commits you dont want

finish rebasing

git push -f

;)

2014-08-05 17:25 GMT+02:00 Makman2 notifications@github.com:

I already thought that... But I think we share this via gist, a file in our beautiful directory is sad -

Reply to this email directly or view it on GitHub https://github.com/Makman2/CE3D/pull/143#issuecomment-51213335.

Makman2 commented 10 years ago

Okay the gist can be found here: remove_trailing_spaces.sh

Makman2 commented 10 years ago

Everything ok with you? If so I'll merge ;D