Closed Makman2 closed 10 years ago
I'm fiddling around a bit with your commits and upload the changed version then. First thing I do with every commit: shorten the shortlog (first line of commit message)
When you do git format-patch or so git will only use the first 50 chars of the shortlog. Therefore it is very common, and I'd like to do that too, to limit the shortlog to 50 chars if possible, hardlimit is 70 chars. It is therefore common to save a few chars by:
Hm okay, I'll do this in my next commits. How do you supply a more detailed commit description?
Usual structure is:
keyword: Short description
A verbose description. Full sentences here. As Long as you want but max 72 chars (IIRC) per line. Vim breaks automatically if you're beyond this in commit messages.
So just two line breaks okay :)
I'm waiting for you to reupload revised patches and will continue review at this point. State here if you think this is wrong.
I make a full rebase with good commits and messages, hope it will look fine :)
shouldnt this pull request be closed?
Ehm don't know, I thought the testimprove2 pull request (#150) doesn't have this commits. If you want only one merge commit you can close this issue and merge #150. Or you can merge this one and then #150.
less pull requests. less complexity.
Migrate to new testutilities and delete the old transformation_test files. Every commit compilable and working.