search

Makman2 / CE3D

A terminal 3D engine
GNU General Public License v3.0
4 stars 0 forks source link

Improve test and testutilities. #150

Closed Makman2 closed 9 years ago

Makman2 commented 10 years ago

Also add make_zero() functions to make near zero values to absolute zero. Needed for relative compares.

sils commented 10 years ago

ah this covers the commits from the other pull request? Can you close the other pull request if its obsolete then?

sils commented 10 years ago

most commit messages are too long, especially the first line. Try to hold 50 chars max! In some cases it might sense to go for up to 70 but only when theres no way to strip something off the line.

sils commented 10 years ago

other commits seem good on first glance except commit message ;) (trailing dot)

Makman2 commented 10 years ago

Because of the rebase of testimprove the whole tree get diverged and I must rebase it completely from ground up (also to apply your fixes). I make several rebases to not forget anything. So please wait with review until I say it's over :)

Makman2 commented 10 years ago

Done.

Makman2 commented 10 years ago

I hope I didn't forget something. I just realized that the discussions are also removed when force-pushing, before I thought to have seen that they will be kept.

sils commented 10 years ago

you forgot some trailing dots in commit shortlog here and there. would you mind correcting that before I continue review?

Makman2 commented 10 years ago

So tested the BOOST_CHECK macros: make attempts an error (Error 2).

sils commented 10 years ago

sounds like it should. good then I'm in for this.

sils commented 9 years ago

thats good looking commit messages!

Makman2 commented 9 years ago

So everything settled for merge?

Makman2 commented 9 years ago

Okay that should be all fixes. If you ack'ed them I'll rebase and merge some commits as you suggested.

Makman2 commented 9 years ago

Will rebase. The obsolete '#' is fixed in 8d663d0.

Makman2 commented 9 years ago

So you can see what changed (I will push more often the rebase-script when rebasing):

pick aa159d9 test: Improve world construction test
fixup 8d663d0 test: Remove empty '#'
pick 950454d test: Move test-case to new test suite
pick 4b58310 test: Improve documentation for RandomMatrix()
pick 187b7be boostext: Add new function make_zero()
pick ac735eb buildsystem: Remove unneeded CMake dependency
pick 0c56136 test: Rewrite testutilites test functions
pick df04065 boostext: Add make_zero function for vectors
pick 31c4d62 test: Change test name
pick 2583e98 test: Improve documentation
pick 3ea72d3 boostext: Add make_zero() function for numerics
pick e674cc9 std: Remove typedef for vector index type
pick fc70539 test: Make optional parameter
pick f4e0e3d testutilities: Make RandomMatrix() more random
pick 9234c73 test/transformation_chain: Use new RandomMatrix()
pick 688925a testutilities: Description for relative checking
sils commented 9 years ago

you can merge this after having squashed those commits I pointed out

Makman2 commented 9 years ago 
pick 23dbdbb testutilities: Make RandomMatrix() more random
fixup b7725de test: Make optional parameter
pick 4cfd267 test/transformation_chain: Use new RandomMatrix()
pick 60aca06 testutilities: Description for relative checking
Makman2 commented 9 years ago

Ah damn... The optinal parameter should go away... It won't work either because of the overload...

Makman2 commented 9 years ago 
edit 6212c6b testutilities: Make RandomMatrix() more random
pick 0a81702 test/transformation_chain: Use new RandomMatrix()
pick 9c0225a testutilities: Description for relative checking