search

Makman2 / CE3D

A terminal 3D engine
GNU General Public License v3.0
4 stars 0 forks source link

Introduce linear function object #165

Closed Makman2 closed 9 years ago

Makman2 commented 9 years ago

The linear function from #162. Additionally extended the test utilities.

sils commented 9 years ago

also look on commit messages on this branch

sils commented 9 years ago

maybe you want to rebase now so I don't have to re-review the other commits again.

Makman2 commented 9 years ago 
pick 55468b3 math: Add linear function handling class
fixup 97542f0 FIXUP WITH FIRST
pick 8f846fe math/linear_function: Add new constructor with CE3D::Vector's
pick e9f9376 testutilities: Add new randomizer functions
pick 15fa753 testutilities: RandomMatrix() uses epoch-function
pick 1517cbb testutilities: Add RandomVector() functions
pick 4e86647 math/linear_function: Add test suite
Makman2 commented 9 years ago

Sorry that the rebase took so long, got some things to do, now is time again for CE3D :)

sils commented 9 years ago

I think you didn't get what I meant, there definitely are other occasions of what I mean but I lack the ability to explain it better. However its not as important so its okay. I'll try to review the rest today.

Makman2 commented 9 years ago

Generally for doxygen comments: Do they support some kind of latex or html postprocessing (i.e. for tables)?

Makman2 commented 9 years ago

From now on I'll push fixup or complementing commits that you can also ack, after that I'll squash them all together with rebase. I think it's better to understand what I've fixed explicitly. Also the github comments do not vanish.

sils commented 9 years ago

I'd have to look up doxygen doc for myself too

2014-12-30 23:25 GMT+01:00 Makman2 notifications@github.com:

From now on I'll push fixup or complementing commits that you can also ack, after that I'll squash them all together with rebase. I think it's better to understand what I've fixed explicitly. Also the github comments do not vanish.

Reply to this email directly or view it on GitHub https://github.com/Makman2/CE3D/pull/165#issuecomment-68405550.

Makman2 commented 9 years ago

Okay I think we got everything. Rebase?

sils commented 9 years ago

rebase. Dont ask, do.

2014-12-31 18:08 GMT+01:00 Makman2 notifications@github.com:

Okay I think we got everything. Rebase?

Reply to this email directly or view it on GitHub https://github.com/Makman2/CE3D/pull/165#issuecomment-68454786.

Makman2 commented 9 years ago 
pick 94b64b1 math: Add linear function handling class
fixup 80fe96d FIXUP WITH 94b64b1
fixup 0fb9214 FIXUP COMMIT FOR 94b64b1
pick 3f4dce9 math/linear_function: Add new constructor with CE3D::Vector's
pick a64aa91 testutilities: Add new randomizer functions
fixup c339430 FIXUP WITH a64aa91
pick befdd8d testutilities: RandomMatrix() uses epoch-function
pick 763fa87 testutilities: Add RandomVector() functions
pick b010ce0 math/linear_function: Add test suite
pick 88779f7 testutilties: New NanosecondsSinceEpoch function
pick 0d09fa7 testutilities: Randomizing functions use NanosecondsSinceEpoch()
Makman2 commented 9 years ago 
reword 6f14963 testutilities: Add new randomizer functions
pick 561cc5b testutilities: RandomMatrix() uses epoch-function
pick ecace6e testutilities: Add RandomVector() functions
pick 3a8da64 math/linear_function: Add test suite
pick 8cfa940 testutilties: New NanosecondsSinceEpoch function
pick c21ddb2 testutilities: Randomizing functions use NanosecondsSinceEpoch()
Makman2 commented 9 years ago

Forgot to post here that I've rebased already...

Makman2 commented 9 years ago

Okay I think you ack'ed everything, feel free to merge (if everything's fine :D)