search

Makman2 / CE3D

A terminal 3D engine
GNU General Public License v3.0
4 stars 0 forks source link

orthogonal_projection: Improve documentation #169

Closed Makman2 closed 9 years ago

Makman2 commented 9 years ago

Simple documentation improvement^^

sils commented 9 years ago

you wouldn't accidentally care for a review of my big PR of coala (150)? I'm waiting since quite some time to get everything on master.

2015-01-18 21:27 GMT+01:00 Makman2 notifications@github.com:

Simple documentation improvement^^

You can view, comment on, or merge this pull request online at:

https://github.com/Makman2/CE3D/pull/169 Commit Summary

  • orthogonal_projection: Improve documentation

File Changes

Patch Links:

Reply to this email directly or view it on GitHub https://github.com/Makman2/CE3D/pull/169.

Makman2 commented 9 years ago

It's hard to review code you really don't understand. I already reviewed some files but found nothing more since the last time^^

sils commented 9 years ago

As I said you already found more than the others. Could you give me a range of commits you've looked at? Then I can merge them.

2015-01-18 21:37 GMT+01:00 Makman2 notifications@github.com:

It's hard to review code you really don't understand. I already reviewed some files but found nothing more since the last time^^

Reply to this email directly or view it on GitHub https://github.com/Makman2/CE3D/pull/169#issuecomment-70424672.

Makman2 commented 9 years ago

I looked until f49ceb1: ConfWriter: Simplify __write_key_val() But I can't guarantee that I missed some errors (especially semantic ones because I don't know exactly what each function does :>).

Makman2 commented 9 years ago

I'll review yours further tomorrow^^

sils commented 9 years ago

If it is not clear what the function does you can ask and I'll improve documentation. I'm setting for highest quality standards for this code so it shouldn't be a difficult task to understand it. Also if there's some special case I didn't test feel free to mention. You can't make a guarantee by the way if you do not mathematically prove the correctness of the code which is a monumental task.

2015-01-18 21:46 GMT+01:00 Makman2 notifications@github.com:

I'll review yours further tomorrow^^

Reply to this email directly or view it on GitHub https://github.com/Makman2/CE3D/pull/169#issuecomment-70425102.

sils commented 9 years ago

Thanks thats great :)

2015-01-18 21:52 GMT+01:00 Lasse Schuirmann lasse.schuirmann@gmail.com:

If it is not clear what the function does you can ask and I'll improve documentation. I'm setting for highest quality standards for this code so it shouldn't be a difficult task to understand it. Also if there's some special case I didn't test feel free to mention. You can't make a guarantee by the way if you do not mathematically prove the correctness of the code which is a monumental task.

2015-01-18 21:46 GMT+01:00 Makman2 notifications@github.com:

I'll review yours further tomorrow^^

Reply to this email directly or view it on GitHub https://github.com/Makman2/CE3D/pull/169#issuecomment-70425102.