Changes to make it work in Symfony 4

Maks3w / FR3DLdapBundle

This bundle integrates LDAP Authentication with any user manager (Ex: FOSUserBundle)

119 stars 77 forks source link

Closed amorebietakoUdala closed 5 years ago

amorebietakoUdala commented 5 years ago

In order work in Symfony 4, I have changed the deprecated DefinitionDecorator for ChildDefinition as the migration docs say. It works without problem.

Maks3w commented 5 years ago

I see. Could you please rebase the branch?

Then I'will release a new major version with a minimum requirement of SF 3.4.

amorebietakoUdala commented 5 years ago

I see. Could you please rebase the branch?

Then I'will release a new major version with a minimum requirement of SF 3.4.

I made the changes in the development branch. And make another pull request in that branch. It's that ok?

Maks3w commented 5 years ago

Thanks. I've close develop branch as it's very outdated does not match with the current maintenance activity. Thanks any way