search

Makuna / NeoPixelBus

An Arduino NeoPixel support library supporting a large variety of individually addressable LEDs. Please refer to the Wiki for more details. Please use the GitHub Discussions to ask questions as the GitHub Issues feature is used for bug tracking.
GNU Lesser General Public License v3.0
1.18k stars 261 forks source link

ESP32-S3 LCD peripheral for 8-bit parallel WS2812X #807

Closed coliniuliano closed 3 months ago

coliniuliano commented 4 months ago

I got this initial version working, tested with 3 strips so far. I removed a lot so that I could understand the logic more easily and because I really only care about the WS2812x strips at the moment. I did a very quick tidy up but this is more for reference and critique. I plan to get 16-bit working next, should be simple enough. I do not plan to add support for other strips.

coliniuliano commented 4 months ago

16-bit support added in the backport PR since my end goal is to use it with WLED.

Makuna commented 3 months ago

Just commenting to let you know I am not ignoring this. I have had a hard time finding the necessary time this pull (and your next) requires reviewing. Thanks.

coliniuliano commented 3 months ago

@Makuna thank you for your excellent review! I'm happy to make these changes but I can't commit to a timeframe right now. My hope is that these open PRs can be useful for anyone who hopes to just get things working quickly, or to encourage new collaborators. At the moment my schedule is insanely busy but I'm hoping I can get some free time in the next weeks. Please feel free to close the PRs if they aren't valuable in their current state - I will be happy to put together something proper when I have some free time to play with electronics again. Cheers!

Makuna commented 3 months ago

@coliniuliano I will merge this and do the final cleanup. Could you please rebase the one based off master to the branch I created for you so I can do the same with it (see that pull for the actual branch).