search

Makuna / Rtc

Arduino Library for RTCs, Ds1302, Ds1307, Ds3231, Ds3232, Ds3234 and Pcf8563/BM8563 with deep support. Please refer to the Wiki for more details. Please use the Github Discussions to ask questions as the GitHub Issues feature is used for bug tracking.
GNU Lesser General Public License v3.0
368 stars 126 forks source link

Method RtcDateTime::InitWithIso8601(const char* date) does NOT scan ISO8601 but rather RFC1123 #124

Closed brewmanz closed 1 year ago

brewmanz commented 3 years ago

Describe the bug Your commented example is "Sat, 06 Dec 2009 12:34:56 GMT", which is RFC1123. ISO8601 (which has many formats) would be more like "2009-12-06T12:34:56" or "2009-12-06T12:34:56+00:00" or "2009-12-06T12:34:56Z".

To Reproduce I just saw the code.

Expected behavior Either parse according to some ISO8601 format, or be renamed to InitWithRfc1123.

Development environment (please complete the following information): All.

Minimal Sketch that reproduced the problem: Use eyeball MkI.

Additional context None.

Makuna commented 3 years ago

@techi602 provided this support.

Makuna commented 1 year ago

InitWithIso8601 is now deprecated method. It has been replaced with InitWithDateTimeFormatString which allows the sketch author to provide a formatting string that defines how to covert the string.

Makuna commented 1 year ago

v2.4.0