search

Malaa-tech / expo-custom-assets

Expo plugin to add custom assets to native codebase
25 stars 3 forks source link

Question. Does this plugin work w/ `expo-updates`? #1

Closed o-alexandrov closed 2 months ago

o-alexandrov commented 4 months ago

Hello, thank you for the plugin. Have you checked whether this plugin works with expo-updates?

mzaien commented 4 months ago

hello @o-alexandrov , I did not get what exactly do you mean but if you meant that the new assets are pushed with expo-update I would guess it does not because as far as my Knowledge expo-updates/codepush just push Javascript code not other assets or native o

o-alexandrov commented 4 months ago

I also think it doesn’t, because assets are added individually by modifying the native files: https://github.com/Malaa-tech/expo-custom-assets/blob/5bd5f1d8aba6303551eeb2ec8bbd22102e9c5f5e/src/index.ts#L132

https://github.com/Malaa-tech/expo-custom-assets/blob/5bd5f1d8aba6303551eeb2ec8bbd22102e9c5f5e/src/index.ts#L64

I think for this plugin to work with expo-updates, this plugin needs to require() individual files and somehow make metro to bundle it (for example by modifying assetExts):

If you ignore support for expo-updates, I think you should add a directory as a group, not individual files