search

Malabarba / aggressive-indent-mode

Emacs minor mode that keeps your code always indented. More reliable than electric-indent-mode.
850 stars 36 forks source link

Always kill timer #139

Closed purcell closed 4 years ago

purcell commented 4 years ago

I found a case where the timer was nil but the particular code path that was calling cancel-timer on it didn't check this, which left me with errors in the minibuffer after every command. I've refactored the code to do this consistently, and made a couple of other minor fixes along the way.

purcell commented 4 years ago

Ping!

purcell commented 4 years ago

Fixes #138, similar to #141 (but likely more complete).

Malabarba commented 4 years ago

Thanks Steve! And sorry for the delay. :see_no_evil:

Can you confirm in a few days if this fixed the problem for good? Then I'll make a stable release.

purcell commented 4 years ago

Thanks Steve! And sorry for the delay. 🙈

Haha, no worries! Thanks for mergning.

Can you confirm in a few days if this fixed the problem for good? Then I'll make a stable release.

Tbh this only happened sporadically, and even without the fix I haven't seen it happen recently: I'm not quite sure how to reproduce it, but clearly other people have seen this behaviour too. I'd suggest just giving it a few days in MELPA and if nobody complains that I've broken things horribly, this should be safe. :D