search

Malabarba / aggressive-indent-mode

Emacs minor mode that keeps your code always indented. More reliable than electric-indent-mode.
850 stars 36 forks source link

Fix aggressive-indent-mode #157

Closed skangas closed 1 year ago

skangas commented 1 year ago

My last commit actually stopped aggressive-indent.el from building:

Compiling file /home/skangas/wip/emacs-packages/aggressive-indent-mode/aggressive-indent.el at Tue Oct  4 00:22:20 2022
aggressive-indent.el:489:2: Error: Wrong type argument: stringp, :lighter

This PR should fix that. Sorry about the mess!

skangas commented 1 year ago

@Malabarba Really sorry about this, but it seems like this needs merging too.

seagle0128 commented 1 year ago

Please merge ASAP. Thanks!

seagle0128 commented 1 year ago

@Malabarba kindly ping... It breaks the startup.

emacs18 commented 1 year ago

This caused my spacemacs startup to fail mysteriously. It took a long time for me to figure out that aggressive-indent was the culprit among dozens of other packages I happened to have updated. I can't recall encountering any other problem that took this long for me to diagnose, because the error message was so cryptic. Hundreds of packages use :lighter tag! Also --debug-init did not help at all.

I think it was especially difficult for me perhaps because I was using straight.el rather than package.el. Sigh. My solution was to just remove the latest change from my git clone.

Please fix this ASAP. Otherwise many folks could be impacted.

haifenghan commented 1 year ago

@Malabarba could you please merge it?

Malabarba commented 1 year ago

Done. Sorry for the delay.