Malabarba / smart-mode-line

A powerful and beautiful mode-line for Emacs.
898 stars 54 forks source link

magit disappeared from mode-line #1

Closed wangyuehong closed 11 years ago

wangyuehong commented 12 years ago

i am using the dotfiles form https://github.com/purcell/emacs.d after installing smart-mode-line, i found that magit menu disappeared from the mode-line, and the other mode name has no reponse when i click them with mouse. emacs 24.1 windows 7 64bit

is it a feature other than a bug.

Malabarba commented 12 years ago

Ok, I'm working on it. Magit menu bug is fixed. All major modes are also clickable now (it brings up the menu as expected).

Minor mode names are not fully clickable yet (only mouse-1 isn't working). Not sure how to fix it yet, but I'll get to it in the next few days.

For now, I'm submitting this partial patch so that Magit will work.

Malabarba commented 12 years ago

Ok, everything should be working now. Could you check if it's working for you?

If you installed from melpa, the new version should be up in a few hours. If you installed manually, just download the current file right here.

You'll know you have the right version if the sml/version variable is set to "1.6.2".

wangyuehong commented 12 years ago

thank yout for your fix and sorry for my late reply. i am using the current version of sml but the magit menu still disappeared in the mode line.

Malabarba commented 12 years ago

Ok. Before I dive into it again, let me know something. Are you using the version from this github, from marmalade, or from melpa?

wangyuehong commented 12 years ago

i am using the version from melpa, it shows ' smart-mode-line 20120713 ' in the packages menu.

Malabarba commented 12 years ago

I'm sorry, but I can't reproduce this bug with my configs.

Bruce Connor

2012/7/26 wangyuehong < reply@reply.github.com

i am using the version from melpa, it shows ' smart-mode-line 20120713 ' in the packages menu.


Reply to this email directly or view it on GitHub:

https://github.com/Bruce-Connor/smart-mode-line/issues/1#issuecomment-7296378

Bad-ptr commented 12 years ago

I'm downloaded the current version(from github). The major mode is on modeline and working(shows menu on mouse click), but there is no minor modes list.

emacs --version  
GNU Emacs 24.1.50.3

(message "%s" sml/version)  
"1.6.2"

In *Messages* buffer:

Error during redisplay: (void-function :eval)
Error during redisplay: (wrong-type-argument characterp (:eval (if (or semantic-highlight-edits-mode semantic-show-unmatched-syntax-mode) #(" S" 1 2 (face bold))))) [114 times]

Maybe it'l help:

(sml/extract-minor-modes minor-mode-alist 30)  
*** Eval error ***  Wrong type argument: characterp, (:eval (if (or semantic-highlight-edits-mode semantic-show-unmatched-syntax-mode semantic-idle-scheduler-mode semantic-mru-bookmark-mode) #(" S" 1 2 (face bold))))

minor-mode-alist:

((hi-lock-mode
  (:eval (if (or hi-lock-interactive-patterns hi-lock-file-patterns)  Hi )))
 (server-buffer-clients  Server)
 (auto-complete-mode  AC)
 (flymake-mode flymake-mode-line)
 (compilation-minor-mode  Compilation)
 (compilation-shell-minor-mode  Shell-Compile)
 (compilation-in-progress  Compiling)
 (outline-minor-mode  Outl)
 (highlight-parentheses-mode  hl-p)
 (autopair-mode  pair)
 (rainbow-mode  Rbow)
 (linear-undo-mode  LU)
 (sgml-electric-tag-pair-mode /e)
 (yas/minor-mode  yas)
 (w3m-minor-mode  w3m)
 (doc-view-minor-mode  DocView)
 (image-minor-mode (:eval (if image-type (format  Image[%s] image-type)  Image)))
 (semantic-minor-modes-format semantic-minor-modes-format)
 (semantic-highlight-edits-mode /e)
 (semantic-show-unmatched-syntax-mode /u)
 (semantic-mru-bookmark-mode /k)
 (linum-mode )
 (visible-mode  Vis)
 (global-visual-line-mode  vl)
 (visual-line-mode  Wrap)
 (next-error-follow-minor-mode  Fol)
 (abbrev-mode  Abbrev)
 (overwrite-mode overwrite-mode)
 (auto-fill-function  Fill)
 (defining-kbd-macro  Def)
 (isearch-mode isearch-mode)
 (iedit-mode iedit-mode))

something about semantic-minor-modes-format:

semantic-minor-modes-format is a variable defined in `util-modes.el'.
Its value is ((:eval
  (if
      (or semantic-highlight-edits-mode semantic-show-unmatched-syntax-mode semantic-idle-scheduler-mode)
      #(" S" 1 2
        (face bold)))))

  This variable is potentially risky when used as a file local variable.

Documentation:
Mode line format showing Semantic minor modes which are locally enabled.
It is displayed in the mode line.
simao commented 12 years ago

Magit is still not shown to me, I am using latest version from melpa.

Malabarba commented 11 years ago

Ok, version 1.7 changed a lot of things.

Is this still happening in 1.7?

Malabarba commented 11 years ago

I'll just file this as closed for now (if it happens to anyone just create a new issue).