search

Malabarba / spinner.el

Emacs mode-line spinner for operations in progress
104 stars 21 forks source link

Remove usage of deprecated cl.el #17

Closed twmr closed 4 years ago

twmr commented 4 years ago

Use cl-lib instead. cl.el is marked as obsolete beginning with emacs27.

tarsius commented 4 years ago

Friendly ping.

Please merge this. I just implemented the same change only to later learn that someone else already did it a few months ago.

Note that you might want to

-;; Package-Requires: ((emacs "24.3"))
+;; Package-Requires: ((emacs "24") (cl-lib "0.6.1"))

if you want to continue to support 24.1 and 24.2. 24 is needed for lexical-binding.

twmr commented 4 years ago

@Malabarba Do we want to continue supporting emacs versions < 24.3 for spinner.el? If yes, I would have to update my PR.

Malabarba commented 4 years ago

Done. Sorry for the looong silence

Malabarba commented 4 years ago

And no, I don't see any need in supporting emacs < 24.3