search

Malabarba / spinner.el

Emacs mode-line spinner for operations in progress
104 stars 21 forks source link

Error with Emacs 26 #8

Closed ptrv closed 4 years ago

ptrv commented 7 years ago

With Emacs 26 I get the following error from Paradox but originating from spinner.el

Debugger entered--Lisp error: (error "Invalid options for slot timer in spinner")
  signal(error ("Invalid options for slot timer in spinner"))
  error("Invalid options for slot %s in %s" timer spinner)
  #[385 ":\203\n@\202\243\303\211\304!\305P\306\307\310\"!\303\306\307\311   \"!\306\307\312\n\"!\303\211\313 \2035\2026\314\303\306\307\315\"!\306\307\316\"!\303\211\211\211\211@;\205X\211A\262\242\303\211\317\320\321\"B\262\203I@:\203v@@\202y@\211A\262\242\243\322=\203\235\211\203D\211@\203\227\304@!\202\230\323\262\202D\324=\203\307\211A\203\274\211@=\203\263\303\262\211B\262\202D\211\203D\211@\262\202D\325=\203\330\211\203D\211@\262\202D\326=\203\351\211\203D\211@\262\202D\327=\203\203\370\330\331!\210\211@\262    \320\332A\"\262\n\202D\333=\203\211@\262\202D\334=\203 \211@\262\202D\335=\203,\336\262\202D\337=\203?\340@\341\"\244\262\202D\330\342\"\210\266\202c\204U\204U   \262\203`\343!\262
\203v\344\345\346D\347BB\350BB\262\202\266\204\266\n\203\227\n\351H\n>\204\220\352\353\354
D\"\210\n\355H\203\266\336\262
\n\204\243\203\251
?\205\264\344\356\307\357\"\360BBD\262\n\203N\n\351H\n>\204\314\352\353\354
D\"\210\n\361H\362\f!\203\346=\204\346\330\363\"\210    \203 @@\236\206\375\330\364@@#>\n\211A\262\f\242\240\210\202\346\365\366\367\236\"\"\262\262\203'\367\236\202(\370\262\f\351H\n>\204;\352\353\354D\"\210\f\371H\203I\262\f\336\262\266\202l\203i\372>\204^\330\373\"\210\203l\262\n\202l\370\262\204z\366\367\236\"\262\204\214\203\214\306\307\374\"!\262\205\352G\367\236>GZ\375>\203\302\376\377\201@\201AGE\201B\201C\201DEEF\202\350\211\351U\203\324\201B\201EE\202\350\376\201F\201B\201G\201HBB
EE\262\262\205\351V\205A@@\201I=\203\201JU\203\376AAAB\202\201KB\262\351\211\203L\211A\262\242\211A\262\242\211\201L>\203Q\303B\262\211\367=\205I\201MDB\262\202C\211\236\203`\330\201N#\210\306\307\201O#!B\262\211A\262\242B\262\201P\201Q\307\201R##\201S\365\205\256\201T\f\352\201U\201V\201M'D\201WBBEEC\201X>\203\303\201C\201D
E\202\332\351U\203\320\201Y\202\332\201G\f\201ZBBC\"BBBBB B\262   \201[G!\203\370\330\201\\#\210\201]\201^\"\203\201_\201`\201a\330\201b\201MDEEE    B\262   \203B\356\307\201c\"\201dBB\201e\201fB\201gBBD\244\210\210\266T\262\202\266\237\262\237\262\203\235\201P\201h\201i@\376=\203x\365\201j\"\202\200\376\201kBB\257B\262\201l\201MD\201m\201MDFB\262\203\264\201n\201MD\201oBBB\262\203\316\201p\366\303\201q!\"BDB\262\211\203d\211@\211@A\211@A\211@A\201r!\201s\201t\201u\201v\201w\201x!\201y\"\201z\201{%\"\"#\201P\201|\303(BBB;\203*\2021\307\201}(\"\365\201~\344\320\201-\"B!\205E\201\200\206M\201xBC\"BBBBB\262\266A\266\202\202\320\210\f\203s
\201\201\336D\244\210\344\201\202\nD\365\237\201\203\201\204\201MD   \201MD\201MD\336=\201M#D\201MD\201MD\201MD\257\nD\201MDD\"BB\207" [cl--optimize-safety cl--struct-default-parent cl-struct-cl-structure-class-tags nil symbol-name "-" intern format "make-%s" "copy-%s" "%s-p" cl--compiling-file 3 "cl-struct-%s" "cl-struct-%s-tags" (cl-tag-slot) mapcar #[257 "\211:\203\207\211C\207" [] 2 "\n\n(fn X)"] :conc-name "" :constructor :copier :predicate :include error "Can't :include more than once" #[257 "\211:\203\207\211C\207" [] 2 "\n\n(fn X)"] :print-function :type :named t :initial-offset make-list (cl-skip-slot) "Structure option %s unrecognized" cl--struct-get-class progn funcall function (cl-x cl-s cl-n) (t) 0 signal wrong-type-argument cl-structure-class 9 princ "#S(%s" (cl-s) 7 ...] 48 ("/usr/share/emacs/26.0.50/lisp/emacs-lisp/cl-macs.elc" . 66994)]((spinner (:copier nil) (:conc-name spinner--) (:constructor make-spinner (&optional type buffer-local frames-per-second delay-before-start))) (frames (spinner--type-to-frames type)) (counter 0) (fps (or frames-per-second spinner-frames-per-second)) (timer (timer-create) :read-only) (active-p nil) (buffer (when buffer-local (if (bufferp buffer-local) buffer-local (current-buffer)))) (delay (or delay-before-start 0)))
  (defstruct (spinner (:copier nil) (:conc-name spinner--) (:constructor make-spinner (&optional type buffer-local frames-per-second delay-before-start))) (frames (spinner--type-to-frames type)) (counter 0) (fps (or frames-per-second spinner-frames-per-second)) (timer (timer-create) :read-only) (active-p nil) (buffer (when buffer-local (if (bufferp buffer-local) buffer-local (current-buffer)))) (delay (or delay-before-start 0)))
  eval-buffer(#<buffer  *load*-217527> nil "/home/peter/.emacs.d/elpa/spinner-1.7.1/spinner.el" nil t)  ; Reading at buffer position 7645
  load-with-code-conversion("/home/peter/.emacs.d/elpa/spinner-1.7.1/spinner.el" "/home/peter/.emacs.d/elpa/spinner-1.7.1/spinner.el" nil t)
  require(spinner)
  (progn (require (quote spinner)))
  eval((progn (require (quote spinner))) t)
  #[128 "\301\302\303B\"D\207" [lexical-binding quote eval progn] 5 1798581]((require (quote spinner)))
  (eval-and-compile (require (quote spinner)))
  eval-buffer(#<buffer  *load*-917441> nil "/home/peter/.emacs.d/elpa/paradox-20161020.1842/paradox-core.el" nil t)  ; Reading at buffer position 4324
  load-with-code-conversion("/home/peter/.emacs.d/elpa/paradox-20161020.1842/paradox-core.el" "/home/peter/.emacs.d/elpa/paradox-20161020.1842/paradox-core.el" nil t)
  require(paradox-core)
  eval-buffer(#<buffer  *load*> nil "/home/peter/.emacs.d/elpa/paradox-20161020.1842/paradox.el" nil t)  ; Reading at buffer position 4222
  load-with-code-conversion("/home/peter/.emacs.d/elpa/paradox-20161020.1842/paradox.el" "/home/peter/.emacs.d/elpa/paradox-20161020.1842/paradox.el" nil t)
  autoload-do-load((autoload "paradox" "Improved version of `package-list-packages'.  The heart of Paradox.\nFunction is equivalent to `package-list-packages' (including the\nprefix NO-FETCH), but the resulting Package Menu is improved in\nseveral ways.\n\nAmong them:\n\n1. Uses `paradox-menu-mode', which has more functionality and\nkeybinds than `package-menu-mode'.\n\n2. Uses some font-locking to improve readability.\n\n3. Optionally shows the number GitHub stars and Melpa downloads\nfor packages.\n\n4. Adds useful information in the mode-line.\n\n(fn NO-FETCH)" t nil) paradox-list-packages)
  command-execute(paradox-list-packages)

Commit eb610f270ea919107b10bb8ece200a87abac6e0e in Emacs source intruduced a check in defstruct which checks the options for a slot and causes the issue.

Should I rather report the issue on emacs-devel?

Thanks

Malabarba commented 4 years ago

Fixed. (See https://github.com/Malabarba/spinner.el/pull/9 )