Malarne / discord_cogs

GNU General Public License v3.0
26 stars 25 forks source link

Updated to not use inline for the leaderboard #66

Closed juliuscaesar1597 closed 3 years ago

juliuscaesar1597 commented 3 years ago

The leaderboard would make a lot more sense if it didn't use the inline embed format, it currently looks ugly: bild

Kreusada commented 3 years ago

I think that you expressing your opinion as 'ugly' really isn't necessary: perhaps it's just not a style you like. I am against this PR because setting inline to false will clutter up the chat more than needed. Anyhow, this isn't my PR or cog, just wanted to express my opinion

juliuscaesar1597 commented 3 years ago

I think that you expressing your opinion as 'ugly' really isn't necessary: perhaps it's just not a style you like. I am against this PR because setting inline to false will clutter up the chat more than needed. Anyhow, this isn't my PR or cog, just wanted to express my opinion

That's understandable! Just thought it would make sense to have leaderboard that's in descending order :)

Malarne commented 3 years ago

i missed that PR that is total nonsense, first off, that's cool wanting to help making any cog better but ... if i merge your PR, first off, you wrote your own name as cog author, iirc that's my cog, you also deleted my other cogs ... sad ... and last one, your idea is not that bad but making some config turning inline True or False might be even better so people can choose how the leaderboard is displayed.