search

Malawi-DCCMS / weather-app

An app to show the weather.
0 stars 0 forks source link

105 let feedback sending actually send data somewhere #109

Open vegardb opened 3 months ago

danielmwakanema commented 3 months ago

@vegardb, it looks good to me. Be nice if the submit URL was configurable and not hard coded.

vegardb commented 3 months ago

@vegardb, it looks good to me. Be nice if the submit URL was configurable and not hard coded.

@danielmwakanema True. And the same applies to API_URL in forecast.slice.ts, so some general config is needed. But is there already any system in place for handling this kind of config?

danielmwakanema commented 3 months ago

@vegardb, no. We have not setup a config system. Let's explore some options.

vegardb commented 3 months ago

I think this should be a separate issue, since it affects other parts than feedback.

https://github.com/Malawi-DCCMS/weather-app/issues/111

fre. 15. mars 2024 kl. 15:03 skrev danielmwakanema @.***

:

@vegardb https://github.com/vegardb, no. We have not setup a config system. Let's explore some options.

— Reply to this email directly, view it on GitHub https://github.com/Malawi-DCCMS/weather-app/pull/109#issuecomment-1999739123, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGULAJPNCXOI7GGFTKXVGLYYL5URAVCNFSM6AAAAABEX4AD5OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJZG4ZTSMJSGM . You are receiving this because you were mentioned.Message ID: @.***>

danielmwakanema commented 3 months ago

@vegardb, I agree.