Malawi-DCCMS / weather-app

An app to show the weather.
0 stars 0 forks source link

refactor(appbar): trigger render on focus #138

Closed danielmwakanema closed 3 months ago

danielmwakanema commented 3 months ago
danielmwakanema commented 3 months ago

@havardf @vegardb, please help me review this before I move on to other tickets, :).

vegardb commented 3 months ago

Looks good! But the back button still shows on the no-location page.

danielmwakanema commented 3 months ago

@vegardb, that is true. Before the app goes to the no location page it first renders the main page and notes that there's no location permissions. It then sends the user to the no location page. Consequently creating some routing history.

vegardb commented 3 months ago

Ok, is it easy to remove it? (the history in that case)

LinUXBele commented 3 months ago

@danielmwakanema From the description, I am not understanding how to test this!

danielmwakanema commented 3 months ago

Ok, is it easy to remove it? (the history in that case)

I am looking at it.

danielmwakanema commented 3 months ago

@danielmwakanema From the description, I am not understanding how to test this!

We want to see that the back button no longer shows up where it is not supposed to be.

LinUXBele commented 3 months ago

It is still showing on the Without location page... @danielmwakanema

danielmwakanema commented 3 months ago

@vegardb, I have pushed through a commit that removes the back button the first time one gets to the no location page. Please have a look.

danielmwakanema commented 3 months ago

It is still showing on the Without location page... @danielmwakanema

Thanks @LinUXBele, that is what @vegardb also pointed out. I have pushed through a change that should resolve this.