Closed danielmwakanema closed 3 months ago
@havardf @vegardb, please help me review this before I move on to other tickets, :).
Looks good! But the back button still shows on the no-location page.
@vegardb, that is true. Before the app goes to the no location page it first renders the main page and notes that there's no location permissions. It then sends the user to the no location page. Consequently creating some routing history.
Ok, is it easy to remove it? (the history in that case)
@danielmwakanema From the description, I am not understanding how to test this!
Ok, is it easy to remove it? (the history in that case)
I am looking at it.
@danielmwakanema From the description, I am not understanding how to test this!
We want to see that the back button no longer shows up where it is not supposed to be.
It is still showing on the Without location page... @danielmwakanema
@vegardb, I have pushed through a commit that removes the back button the first time one gets to the no location page. Please have a look.
It is still showing on the Without location page... @danielmwakanema
Thanks @LinUXBele, that is what @vegardb also pointed out. I have pushed through a change that should resolve this.