search

Malawi-DCCMS / weather-app

An app to show the weather.
1 stars 0 forks source link

Icons sizes are off after changing iconset #151

Open LinUXBele opened 6 months ago

LinUXBele commented 6 months ago

Please change sizes to reflect the sizes in Figma.

Image

LinUXBele commented 6 months ago

This is what I see in the latest version

Image Image Image

vegardb commented 6 months ago

Specified sizes in react-native are already larger than in figma. I believe the problem is the frame around the images. Could probably be fixed either with more closely-cropped images, or with some css magic.

Image

vegardb commented 6 months ago

I have cropped the images more closely - see https://github.com/Malawi-DCCMS/weather-app/pull/155/files

At the same time, I have increased the display size of some of the the images.

It seems to be very hard to come up with a correct size, since it is hard to figure out what is the correct cropping for each image.

LinUXBele commented 6 months ago

Indeed. And there are 83 icons to crop. I can crop them, but it will take some time. And if we ever want to change the icon set, they will have to be recropped. I can have them re-cropped before standup tomorrow!

LinUXBele commented 5 months ago

Tested OK!