Closed vegardb closed 5 months ago
A few questions related to how select the weather data to show:
In today's forecast we show data for the current hour (eg. at 11:24 we show data for 11:00). Did we want that, or for the coming hour?
Does not specify what happens at exactly 04:00 - maybe change the implementation so that it is a series of isBefore statements?
isBefore
If I read the code correctly:
undefined
Also, there is a default fair_day show whenever getWeatherIcon returns undefined
fair_day
There seems to be some bugs related to how weather symbols are selected.
A few questions related to how select the weather data to show:
Today's forecast
In today's forecast we show data for the current hour (eg. at 11:24 we show data for 11:00). Did we want that, or for the coming hour?
Does not specify what happens at exactly 04:00 - maybe change the implementation so that it is a series of
isBefore
statements?DayRow - getWeatherIcon:
If I read the code correctly:
undefined
if time <= 04:00Also, there is a default
fair_day
show whenever getWeatherIcon returnsundefined