search

MalaysiaPrayerTimes / android

An Android app to remind when the next prayer is due, search nearby mosques, and determine the qibla.
https://play.google.com/store/apps/details?id=com.i906.mpt
Apache License 2.0
41 stars 27 forks source link

Display an appropriate error message if location could not be retrieved. #15

Closed AhmadMuzakkir closed 7 years ago

AhmadMuzakkir commented 7 years ago

I override getErrorMessage() on the affected fragments.

Not sure whether I should change it on the base getErrorMessage().

i906 commented 7 years ago

I prefer that the error messages are got from getErrorMessage() in BaseActivity.

PrayerFragment and MosqueFragment will specially handle those exceptions. For SecurityException the fragments the button would request the permission while the TimeoutException would retry as usual.

i906 commented 7 years ago

Closing in favor of https://github.com/MalaysiaPrayerTimes/android/pull/19.