Maldela / fancontrol-gui

GUI for Fancontrol. It uses the KAuth module of the KDE Frameworks 5 to write the generated config file. Furthermore it communicates with systemd via dbus to control the fancontrol service. If you want to compile without systemd support set the -DNO_SYSTEMD option.
GNU General Public License v2.0
319 stars 31 forks source link

CMake issues on KDE neon 5.14.5 #23

Closed win8linux closed 5 years ago

win8linux commented 5 years ago

When trying to run cmake .. -DCMAKE_INSTALL_PREFIX=/usr -DBUILD_KCM=on on KDE neon 5.14.5, it fails with this:

CMake Error at /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  Could NOT find Gettext (missing: GETTEXT_MSGMERGE_EXECUTABLE
  GETTEXT_MSGFMT_EXECUTABLE)
Call Stack (most recent call first):
  /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake-3.10/Modules/FindGettext.cmake:80 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  /usr/lib/x86_64-linux-gnu/cmake/KF5I18n/KF5I18nMacros.cmake:28 (find_package)
  /usr/lib/x86_64-linux-gnu/cmake/KF5I18n/KF5I18nConfig.cmake:43 (include)
  /usr/share/ECM/find-modules/FindKF5.cmake:74 (find_package)
  CMakeLists.txt:51 (find_package)

This is already after installing the necessary deps from the readme.

Maldela commented 5 years ago

This looks like you are missing gettext. Try installing it. If it works, I'll add it to the dependencies.

win8linux commented 5 years ago

Yes, that fixed the issue with CMake. I've opened a pull request for it here along with updating the tested system note.