Malex21 / CreateBigCannons-BallisticCalculator

A python program that will give you the right orientations in order for your cannon to hit a target
GNU General Public License v3.0
9 stars 3 forks source link

Calculator Angles not Working #2

Closed Nathan3-14 closed 10 months ago

Nathan3-14 commented 11 months ago

I am using computercraft along with this in forge 1.18.2 in order to aim the cannons. It doesn't aim correclty, and misses by a significant amount of pitch. I have sequenced gearshifts as periferals and I am running the .rotate method on them. It also rotates by less than the inputed amount. If I am doing something wrong or if it is possible to fix, it would be greatly appreciated.

Code:

-- code is not exact, becuase long names of periferals
yaw = periferals.wrap("SequenceGearshift_1")
pitch = periferals.wrap("SequenceGearshift_2")
yaw_value = 0 --value here (0-360)
pitch_value = 0 --value here (0-360)

yaw.rotate(yaw_value)
pitch.rotate(pitch_value)
Malex21 commented 11 months ago

Hey ! Sorry for the late response.

Could you give an example of false input ? I know that for some input, the calculator currently miscalculates greatly the pitch (iirc it often happens with very close targets) but there is a fix for that in a commit by SpaceEye I did not merge yet, but this might fix your issue. This could also be a problem from .rotate(), as far as I know very few mechanisms let you have precise angles on your canon.

BowBoy1 commented 10 months ago

Having issues with this as well. I'm consistently overshooting by a lot, regardless of how far the target is from the cannon.

BowBoy1 commented 10 months ago

propellant was doubled in strength, you might wanna update the calculator to account for that

Malex21 commented 10 months ago

It is done ! I built the new exe and added spaceeye's commit (which should fix simulated projectiles not hitting target when still going up)

Malex21 commented 10 months ago

Hello again ! I'm gonna close this issue (i will assume the lack of response means that you have found a solution to your problem) Please re-open if I shouldn't close this tho