search

Malikk / Shield

Shield - A collection of common Bukkit protection plugin API
http://dev.bukkit.org/server-mods/shieldapi/
3 stars 3 forks source link

add Factions 1.8.0 support #4

Closed IDragonfire closed 11 years ago

IDragonfire commented 11 years ago

add Factions 1.8.0 support Factions 1.6.x support also possible, but only with dirty tricks, gives problems with included libs (same packages, but completly reworked) ...

IDragonfire commented 11 years ago

I forgot to add the Plugin in the Shield.java in these commit :( I hope that is not a problem ...

Malikk commented 11 years ago

I can add it in the main class, that's no problem.

Thanks

IDragonfire commented 11 years ago

You can improve the code a lot: https://github.com/IDragonfire/Shield/commits/master I can continue my work, if you like it :)

Malikk commented 11 years ago

Actually, there's quite a few methods in the Protect_Factions class that still need to be done. I made every Protect_Class extend your template class, and then took everything that needs to be implemented on a per plugin level out.

Your pull actually broke quite a few things, but I reorganized, refactored, and otherwise entirely rewrote it back to working condition, lol.