Error: target must be a playlist when dragging

Mallander / playlist-enhancer

Enhanced Playlist curation

MIT License

4 stars 2 forks source link

Error: target must be a playlist when dragging #5

Closed CydGoblin closed 3 years ago

CydGoblin commented 3 years ago

Foundry 0.8.7 system DnD5e

When I try to drag a song to another playlist I get the error "the target must be a playlist"

Mallander commented 3 years ago

Thanks for raising, I'll take a look and fix in the next update

Mallander commented 3 years ago

If possible, would you be able to record this happening and send me a video? (GIF etc is also fine too)

It will help massively with the investigation.

Mallander commented 3 years ago

Hi @Turqueso,

I've not been able to replicate this error myself (Fresh install, 0.8.7 DnD5e), so I'm going to add some extra error wording and debug in the next release to help narrow down where/why this is happening for you.

Hopefully that should let us find out the cause.

Mallander commented 3 years ago

Latest release has just gone out. I couldn't replicate any bug that caused this behaviour so I've updated my error messaging to hopefully dig deeper into the issue.

Please could you let me know whether the error still occurs and what error messages you're now seeing?

CydGoblin commented 3 years ago

I tired again and same issue

Details foundry 0.8.8 playlist enhancer 1.1.1 Firefox 89.0.2 (tested on mac and windows)

Steps

New world. Activate playlist enhancer. No other modules.
Creat 2 playlist, add a song to each
Drag and drop song to the other playlist
getting this error:
Console log:

Am I doing something wrong o is there something else I should do to debug?

Mallander commented 3 years ago

Thanks for reporting back!

So based on that debug (thanks for sharing it!) it thinks you're dragging the playlist onto the canvas rather than another playlist. Not sure why it would be doing that... a few more questions from me:

Do you have FVTT in a smaller window, or maximised?
If you create a Playlist Folder and drag onto there, does the error change?
Do you have the capability of recording a GIF of you dragging the playlist across just so I can see for myself what actions you're taking?

I'll run some more testing in Firefox myself and see if that's causing the issue.

Thanks!

Mallander commented 3 years ago

I'll also see if there's a more robust way of doing the entire drag & drop functionality if I can't find anything concrete in the above.

Mallander commented 3 years ago

Success! It's a firefox bug and I can replicate it!

Will be fixed in the next release.

CydGoblin commented 3 years ago

* Do you have FVTT in a smaller window, or maximised?
Maximised firefox window, but i tried to changing sizes with same result. I just tried chrome(on mac) and it works! so is a firefox thing it seems.
* If you create a Playlist Folder and drag onto there, does the error change?
Same error.
* Do you have the capability of recording a GIF of you dragging the playlist across just so I can see for myself what actions you're taking?
Webm with a short video

Mallander commented 3 years ago

Thanks for all your help investigating the issue, I've found the problem and am fixing it as we speak!

Mallander commented 3 years ago

A new release has just been pushed out which should fix this issue. Please let me know if you're still receiving any errors.

CydGoblin commented 3 years ago

It works now! thank you!

Mallander commented 3 years ago

Awesome, let me know if you run into any other issues!