Feature Request - implementing the Playlist Importer functionality - Githubissues

Mallander / playlist-enhancer

Enhanced Playlist curation

MIT License

4 stars 2 forks source link

Feature Request - implementing the Playlist Importer functionality #6

Open apoapostolov opened 3 years ago

apoapostolov commented 3 years ago

Playlist Importer is a mod that is no longer in development and not supporting 0.8.x playlist metadata additions. Playlist Importer is available here https://github.com/JacobMcAuley/playlist_import

What this mod does is, after setting a core folder on your drive or S3 storage, adds a button that imports all new sounds using "folders become playlists" file structure, set them defaults (only volume is supported, as this mod is no longer supported for 0.8). Existing sounds that match file names are not imported.

Since this mod is adding Bulk Edit, it can use this Bulk Edit defaults to import playlists from a file structure and set their default properties.

Mallander commented 3 years ago

Playlist importer was replaced with core functionality in 0.8.x if I'm not mistaken which is why it's no longer in active development, so I'd likely not recode that function but rather see what I can add to it for bulk editing of imported sounds.

apoapostolov commented 3 years ago

Not completely. Playlist Imported allowed to have a directory structure that you can reimport multiple times, adding only the newly added sounds. There was a button to wipe the memory of previously imported sounds if you wanted to make a full import.

0.8.x Bulk Import would reimport as new files duplicate sounds. It also doesn't set defaults to them.

Mallander commented 3 years ago

Ah I see - I'll look into it!

Mallander commented 3 years ago

Just to set the scope for this feature, which is enhancements to the core "bulk import" funtionality to allow:

Dialog option to replace/skip/duplicate sounds when adding to an existing playlist
Open Playlist Enhancer's "Bulk Edit Sounds" when using the bulk import to edit the playlist.

apoapostolov commented 3 years ago

I would personally go with Settings rather than dialog. Default behavior should be to skip sounds that already exist in a playlist.
Instead of opening Bulk Edit Sounds, apply the default (as set in Bulk Edit Sounds or in Settings) to all added sounds.

Mallander commented 3 years ago

The only problem with the first being solely settings is that the requirement can change depending on what tracks you're importing and if it were me I'd only realise that after running the import - settings would be used to choose a default option so a simple "yes" would be all that you'd need to press to continue the default action to reduce overheads a little.

Second point I feel this is a large change to a large amount of sounds without a confirmation from the user so I'd at least have a yes/no confirmation on apply bulk-edit defaults to the sounds.

apoapostolov commented 3 years ago

I don't mind that much, my main issue is showing too many dialogs to the user when he has a default behavior. Usually the default behavior is "add only sounds that are missing from this playlist, and remove those that I have removed from the folder since their URL is no longer functioning" and "apply default settings to all new added songs so they match the rest of the playlist".

But I have to agree that importing sounds will be a relatively infrequent occasion, not multiple times per session, so it is okay to show a dialog.

Mallander commented 3 years ago

I did have a look into this but haven't had much time recently to work on big features like this - It will be one I'll keep in the backlog for future releases, though!