Infinite loop is breaking the software

[mananas77]

Describe the bug

1. The software always become stuck in a loop, and never gets completed when i try to download all the posts of a subreddit.

2. It's seems that the software encounter some sort of download error that it can't recover from and then get stuck in a loop. I've tried to wait more then 18 hours without any progress at all.

3. At this point i'm unable to do any action related to "Stop Download" And "Terminate Download".

4. When i finaly exit the software it's still running in the background and i have to Terminate in task manager.

5. If i start again and try to download or "Run unfinished". It gets finished in 3 sec without any new files downloaded. And at this point i'm locked from downloading any remaining posts and have to delete the database to get a new chance.

6. It also seems that the url extraction part works while i'm running my download and something gets dumped into the database. But the database don't seem to recognice if the url has been downloaded or not and tells the software "if url is in the database, don't download".

Environment Information

• Windows 10 Home
• Every Software version from v3.0.0-beta up-to the current build.
• Tried every compiled version.

Steps to reproduce my latest encounter of the behavior:

1. Start with a fresh build of the latest software version (Remember to remove your old config and db)

2. Go to settings and add Imgur credentials (or else you get more errors)

3. Add a new subreddit like "aww" or try with a couple that have many images and videos.

4. Use these settings on the subreddit and everything else default.

4. Start the download and let the bug begin.

5. The extraction of all urls will get completed but not the downloading part. (Terminate software in task manager when you get bored and try again with same result)

For all but the most trivial of issues, please attach the latest log file.

DownloaderForReddit.log

[MalloyDelacroix]

I believe I'm narrowing in on this issue. If you wouldn't mind to run a follow up test for me, I can verify that I'm on the right path. Can you run this again exactly the way you described, but go into settings under "core" and change the multi-part download threshold to 10 GB. Let me know if it runs correctly after doing this.

[mananas77]

Yes you are right, with "multi-part download threshold 10 GB" it did go all the way to completion. I did two tests in the same manner with the new threshold.

First test:

1. Completed but about 100-150 console output errors in relation to "Url:https://v.redd.it/**"

ERROR: Failed to extract due to: Unsupported domain ERROR: Failed to extract due to: Unknown error occurred ERROR: Failed to extract due to: Unsuccessful response from server

2. Also got spammed with some hundred cmd.exe windows related to FFmpeg

Log: DownloaderForReddit.log

Second test

1.Here i wanted to end the download midway but was not allowed to stop or terminate download. It just kept going.

2. I did shutdown the software and started up again anew

3. Tried to run unfinished downloads again to get the remaining 500 posts but only got this output

Log: DownloaderForReddit.log

[mananas77]

I just did a Third longer test with more subreddits that was a real pain in the butt

1. After about 22 minutes the progress bar went missing

2. When FFmpeg started to do its thing the computer was unusable with all the popups. There was certainly more than a thousand and every couple of minutes i had to make manual decitions like this one:

3. With all manual decisions that had to be done to continue downloading the progress was a lot slower and tedious but it did complete in the end.

DownloaderForReddit.log DownloaderForReddit2.log