search

MalloyDelacroix / DownloaderForReddit

The Downloader for Reddit is a GUI application with some advanced features to extract and download submitted content from reddit.
GNU General Public License v3.0
498 stars 47 forks source link

Lots of issues with Userlists #184

Open T-prog3 opened 3 years ago

T-prog3 commented 3 years ago

This is what i did to encounter lots of issues:

  1. I Started by adding a Subreddit and download about 100 posts that i saved by "Save path Structure: %[author_name]" I then took these 100 users and put them into a textfile because this apparently is the only way to import more than one user at a time without the tedious process of entering one username and pressing + and so on....

  2. When i have opened the textfile with the users they all get added but the "Names in List:" counter at the top remains at 0 and wont update.

  3. When i then have checkmarked "Download on Add" and Press OK. I get an error saying "username, username, username, username, username, username, username, username, username, username, username is already in the list" This is by far the largest window size in the world. But when i press OK on that window all users imports as they should. (There is no error if "Download on Add" is not checkmarked).

  4. When i have all the new users added to my list i get the next issue. None of the new users inherits the settings from the list and always have the default settings. So every time i add new users i must select them and change the settings manually.

  5. During the download process there is some bug that sometimes show me a window with a message like "Deleted is not a valid username, do you want to remove from list, Yes , No" And i don't even have a user with that name.This happens more frequently with larger userlists.

  6. Select more than one user, Left-click and go to delete user. Only one user gets deleted and when you left-click again the software crash.

Environment Information

MalloyDelacroix commented 3 years ago

When entering users in the multi-add dialog, you can hit enter to add the user to the multi-add list, you don't have to click the "+" button every time. This may be somewhat less tedious.

If entering users one at a time is too tedious, and importing a list of names from a text file is likewise unsatisfactory, what solution do you propose for bulk adds?

When "Download on Add" is checked and you add the imported users, are you adding them to a blank list or a list that already contains users? If the list already contains users, does it already contain some of the users being imported?

Whenever you download a post from a subreddit and the author of the post has deleted their account, a user named "deleted" is created in the database and is assigned the post. This "user" is used for all subsequent posts in which the author has been deleted. If you are adding users in the manner that you described, it is very likely that you do have a user in your list named "deleted". Using the naming method you specified, "deleted" would be taken as the name of a deleted author. If you then try to download this user, it cannot be validated as a real user with reddit and you see the message that you are getting. This is not a bug, this is the correct behavior for invalid users in the download list.

T-prog3 commented 3 years ago
  1. To be honest version 2.3.4 of the software had a more simple approach with bulk adds. There it was possible to just copy & paste. Lets say i had made a copy of my user list and just wanted to import every user from G-H. Then i could select every row from G-H and do Ctrl + C and go to add in the software and press CTRL + V in the input field and every entry got imported without even pressing enter, I Could also see if the user was Removed or not with a checkmark/cross to the left.

In the newer verisons it takes more time. I must create new files to do this and localize the file in explorer. Then remove the file when i'm done. In my opinion the older approach was a lot more effective and faster.

2.Yes this happens both with a newly created blank list and lists with users already in it but still no duplicate values.

I just did a test where i got some users who was not part of the initial Subreddit download and then there was no error with checked "Download on Add". So it appers as if the Subreddit download list and Userlist have some relationship that says if user contains as a Database entry in Subreddit list then give an alert in User list.

  1. As i said i just got 100 validated users from a subreddit. That is 100 folders with each users name and none is named "deleted". So that should be 100 validated users who i can add to a list without issues and download all of these users content. But still i get alerted in the middle of the Downloading process about a user named "deleted" who i do not know where it come from, or gets created because there is no one by that name in both list and folder. This issue is something i've not seen in previous builds and is a more recent one. There have always been a name of the user who deleted their account and their folder would be renamed to username (deleted). But never a user who does not exist. And never an alert about the same user twice during the download process.
MalloyDelacroix commented 3 years ago

I had forgotten about the copy and paste option. I'll add that back in. I'm still working on the other issues.