search

MalloyDelacroix / DownloaderForReddit

The Downloader for Reddit is a GUI application with some advanced features to extract and download submitted content from reddit.
GNU General Public License v3.0
507 stars 48 forks source link

Every name I give is invalid. Then won't launch anymore. Process appears in task manager and then closes right away. #254

Open Proutbedaine opened 2 years ago

Proutbedaine commented 2 years ago

OS: Windows 10 64-bit Version: Latest release

I used it yesterday and today without an issue. Worked super well and was really pleased. It downloaded all the posts from 88 users and one small subreddit. It even worked and did it's job with it's scheduled download twice.

Then one or two hours ago I tried adding a subreddit that clearly exist (I even copy pasted the name to make sure). and it came back saying the subreddit name is invalid. I then tried with a new username, same issue. Whatever I tried they were all invalid. So then I closed it to then reopen it but it won't open anymore. All it does is think for a second and then nothing happens at all (process appears in task manager and then closes right away) In the logs it mentioned errors when I was trying to give it names and then critical errors when trying to launch it again. See for yourself. Is there any way I can fix this?

Here are the logs: DownloaderForReddit.log

MalloyDelacroix commented 2 years ago

It looks like this issue is being caused by PRAW receiving a 400 response from reddit. It initially received it from trying to verify the users/subreddits you were trying to add, then it received it by checking to see if you were using a connected account on application startup. The exception on startup was not handled properly, which is why it was crashing.

This error does not seem to be on our end, but is occurring within PRAW. For some reason, PRAW is not able to connect to reddit. It could be reddit imposing a rate limit, or it could have just had trouble connecting at that time.

I can (and will) fix the app crashing because of this error, but unfortunately, that won't help you since a connection is still required. The only solution I can propose is to try it again after some time has passed. If you keep trying and this persists, please comment letting me know.

Proutbedaine commented 2 years ago

It looks like this issue is being caused by PRAW receiving a 400 response from reddit. It initially received it from trying to verify the users/subreddits you were trying to add, then it received it by checking to see if you were using a connected account on application startup. The exception on startup was not handled properly, which is why it was crashing.

This error does not seem to be on our end, but is occurring within PRAW. For some reason, PRAW is not able to connect to reddit. It could be reddit imposing a rate limit, or it could have just had trouble connecting at that time.

I can (and will) fix the app crashing because of this error, but unfortunately, that won't help you since a connection is still required. The only solution I can propose is to try it again after some time has passed. If you keep trying and this persists, please comment letting me know.

Ohhh oki yeah I see. I wondered if it wasn't on their end too since the 400 errors usually is a communication issue but everything else worked fine. So I wondered if it was on reddit's end the issue or something. But yeah I'll try later and see if it persists for a while and will come back to you if it works and if not I'll try a couple of times before telling you about it. :)

Proutbedaine commented 2 years ago

Ok so I was still crashing and for the same reasons in the log: DownloaderForReddit.log

Then I decided to test out a few things and by deleting my config file and trying to launch it it worked! So something in my configs were the issue. And from what you were saying it was probably my account? Although my account has no issue whatsoever on reddit itself. So would it be better if I didn't link my account? What does it change exactly? What is the advantage of doing so? :v

Then just to see, I downloaded the newest version with the fix so it doesn't crash on launch at least, but then I wondered if it would fix my problem with my configs. I backed them up so I copied them back in the proper folder and tried opening the app with the latest version and...as you can see in the log it did the same issue. So for now I'll redo my config and not connect my account until your next reply.

Oh and I copy pasted most of my settings from the old file to the new one except the account token stuff. And it worked :P. So it really is my account that was linked that was the issue. Dunno why personally though,

I hope this might help figuring things out on your end! :)

MalloyDelacroix commented 2 years ago

Since this is persisting, it may be something on our end afterall. This will require some more investigation.

Having a connected reddit account just allows you to have less of a rate limit imposed by reddit. If you are happy with the download speed that you are getting with an unconnected account, there is probably no advantage. Other features will be available in the future that take advantage of a connected account, but there are none at the moment.

Proutbedaine commented 2 years ago

Since this is persisting, it may be something on our end afterall. This will require some more investigation.

Having a connected reddit account just allows you to have less of a rate limit imposed by reddit. If you are happy with the download speed that you are getting with an unconnected account, there is probably no advantage. Other features will be available in the future that take advantage of a connected account, but there are none at the moment.

Oh oki thanks for the info. It's good to know! And I wish you good luck on finding out what is the issue exactly! ^^