search

MalloyDelacroix / DownloaderForReddit

The Downloader for Reddit is a GUI application with some advanced features to extract and download submitted content from reddit.
GNU General Public License v3.0
506 stars 47 forks source link

new update download to c drive instead of user specified path #303

Open ericsia opened 2 years ago

ericsia commented 2 years ago

Describe the bug After update when I run unfinished extraction, it downloads everything to C drive "Downloads\RedditDownloads" path while I ald specified the path as D Drive. Now the database for failed extraction is all messed up I guess, can you prive and option to delete all failed extraction to new update please? Also the DB is now about few GB after using it for so long, it could really use a DELETE option now.

Environment Information

To Reproduce (optional) Steps to reproduce the behavior:

  1. Go to 'Download'
  2. Click on 'Run all unfinished'

For all but the most trivial of issues, please attach the latest log file.

Note: All issues marked with the Information Needed label will be closed after 30 days if no information is provided.

MalloyDelacroix commented 1 year ago

I think the issue here is that when the content was saved in the database, it used whatever save path you had designated at the time. When you run unfinished downloads later, after having changed the save path for the application/list/user/subreddit, it downloads the content according to what was stored in the database.

I am working on the best way to implement database cleanup. I think I originally underestimated how much content some users download and did not expect database sizes to be a pressing issue.

ericsia commented 1 year ago

I think the issue here is that when the content was saved in the database, it used whatever save path you had designated at the time. When you run unfinished downloads later, after having changed the save path for the application/list/user/subreddit, it downloads the content according to what was stored in the database.

I am working on the best way to implement database cleanup. I think I originally underestimated how much content some users download and did not expect database sizes to be a pressing issue.

@MalloyDelacroix how is the cleanup? Is it possible to implement at least cleanup for previous year? Like now 2023 so clean database item before 2023 year.

I have another suggestion, some reddit user keep spamming, so it will be nice if DFR can implement a "don't download this user" from a config like Don't Download User.toml