Malopieds / InnerTune

A fork of InnerTune, a Material 3 YouTube Music client for Android
GNU General Public License v3.0
439 stars 21 forks source link

Download status/button does not display properly in bigger playlists #133

Closed Irobrine closed 1 month ago

Irobrine commented 3 months ago

Checklist

Steps to reproduce the bug

  1. Go to a playlist with more than a certain number of songs (not sure how many exactly, tested on 2 playlists with more than 900 songs).
  2. Download every song in the playlist.

Expected behavior

The playlist download button should show that the playlist is downloaded when every song in the playlist is downloaded.

Actual behavior

The playlist download button shows that the playlist is not downloaded.

Screenshots/Screen recordings

Playlist where the bug occurs (Big playlists): Screenshot_2024-06-25-17-57-27-514_com zionhuang music Playlist where the bug doesn't occur (Small playlists): Screenshot_2024-06-25-17-58-10-634_com zionhuang music

Logs

log.txt

InnerTune version

0.5.7-rc-2

Android version

Android 14

Additional information

Doesn't seem to only be a visual bug as it causes the "Do you really want to remove all "playlist name" playlist songs from the Downloaded Songs storage?" (Shown in the screenshot below) to not appear when the download button is tapped. Screenshot_2024-06-25-18-22-33-986_com zionhuang music This causes the downloads of some songs in the playlist to be inadvertently deleted when the download button is tapped. Weirdly, after some songs are deleted, it starts to download every song in the playlist again.

Malopieds commented 3 months ago

Where did you found a 900+ song playlists? Does this apply to local playlist only ? What happens if you click on select all?

Irobrine commented 3 months ago

Where did you found a 900+ song playlists?

I imported the playlist from YouTube.

Does this apply to local playlist only ?

Doesn't every playlist become local when imported?

What happens if you click on select all?

It displays 946 elements selected. After tapping select all and then the three dots, the download button is still in the incorrect state (not downloaded). Screenshot_2024-06-27-00-57-24-750_com.zionhuang.music.jpg

Here's the playlist in question if it helps with debugging: https://youtube.com/playlist?list=PL1fqDrekyiuQ-EaVKtJs5CMZxQiQ0ZEnV

Malopieds commented 3 months ago

Doesn't every playlist become local when imported?

Yes exactly, but it was a imported playlist and I think some of the issue might come from YouTube that's why I asked.

It displays 946 elements selected.

From you local playlist or from the YouTube playlist?

For example, from your link it only shows 166 songs and when selecting all it show only 100: Screenshot_20240626-211142.png

But if I import it and then sync it, it shows 936. I will check if the 100 songs limits apply also to the downloading songs...

Irobrine commented 3 months ago

From you local playlist or from the YouTube playlist?

Local playlist imported from YT.

But if I import it and then sync it, it shows 936. I will check if the 100 songs limits apply also to the downloading songs...

It downloaded ~930 songs when the playlist had ~940 songs.

Found a song in the playlist that can't be downloaded due to "No stream available": Screenshot_2024-06-27-13-10-07-573_com.zionhuang.music.jpg

Screenshot_2024-06-27-13-10-16-846_com.zionhuang.music.jpg

Is there any way to remedy this? (i.e. Remove the song from the complete download count)

Irobrine commented 3 months ago

Found a song in the playlist that can't be downloaded due to "No stream available":

Managed to fix it by following #87 (Deleted the app and not use a backup) Screenshot_2024-06-27-13-27-12-476_com.zionhuang.music.jpg

Close the issue if you deem it appropriate

Malopieds commented 1 month ago

Hi, the no stream available has been solved in latest commits, could you tell me if it fixes your issue too?

Irobrine commented 1 month ago

Yep, it did. Thank you.