Malopieds / InnerTune

A fork of InnerTune, a Material 3 YouTube Music client for Android
GNU General Public License v3.0
433 stars 22 forks source link

Player is lagging since 0.5.9 #304

Open Richard38907 opened 1 month ago

Richard38907 commented 1 month ago

Checklist

Steps to reproduce the bug

Opening animation of the mini-player is lagging since v 0.5.9

Expected behavior

Fluid animation

Actual behavior

Lagging animation

Screenshots/Screen recordings

No response

Logs

logcat.txt

InnerTune version

0.5.9

Android version

Android 13

Additional information

No response

Malopieds commented 1 month ago

Could you show me how noticeable it is with a screen record? I don't see any major differences.

Richard38907 commented 1 month ago

Sadly, screen record doesn't render the issue because the video recording makes my phone lagging too 😅😅. I use OnePlus Nord and I notice a noticeable UI performance drop compared to 0.5.8 or z-Huang's version.

Richard38907 commented 1 month ago

By the way. "Gradient player" theme makes the player lag too since the release of this theme.

Malopieds commented 1 month ago

I'm using a 90Hz screen and I mean I don't really see a difference by the simple eye between my fork and the original. Plus the gradient theme has been there for more than a month and no complaint :/ What phone are you using?

Richard38907 commented 1 month ago

OnePlus Nord with Pixel experience 13 ROM installed.

Richard38907 commented 1 month ago

I tested on my OnePlus 10t ( OxygenOS 14) now and the glitch is not present. Weird🤔

Richard38907 commented 1 month ago

No I understand. It's only on AMOLED mode. It lags on two phones with this mode activated. Screenshot_20240813-222442_InnerTune.png When the player is in pure black theme, the glitch occurs.

Malopieds commented 1 month ago

Yeah since AMLOED dark pixel are actually turned off, it might be the cause of "lagging" (which will be in that case just the amoled pixels that are turning on)

Richard38907 commented 1 month ago

I use a lot of apps with pure black mode and they don't lag. The Z-Huang latest version has the pure black player and it doesn't lag. The difference is really noticeable👁️.

Malopieds commented 1 month ago

There is only one difference from z-huang black theme, it's the moment to which I activate the dark mode, but that's what I found frustrating with their implementation, you sometime get the dark mini player when it shouldn't :/

Richard38907 commented 1 month ago

I really would like to help you more to find the cause of this issue but I have no experience in software coding.

d4f5409d commented 1 month ago

I see gradient often loading a whole lot after the start of the song.. I don't know what's the cause of this issue...

d4f5409d commented 1 month ago

And when I swipe up to see the queue, half of the queue UI is not appearing for the one second I swipe up then it reappears after the animation has ended and the screen stays without input again. It's like the queue was cut in half so we are able to see what's behind it (the currently selected tab in Innertune)

Malopieds commented 1 month ago

I see gradient often loading a whole lot after the start of the song.. I don't know what's the cause of this issue...

It's the time for extracting the colors can't do much about it. But it takes max 2 seconds.

There is already an issue for the second thing you described.

Richard38907 commented 1 month ago

Z-Huang pushed the 0.5.7 update with a new animation when opening the mini player (dark-> black with a smooth gradient). And since this new animation, the opening animation is now lagging like this version of this fork😕. https://github.com/user-attachments/assets/eb5610f3-1503-41d9-963a-9e83d99f8b69

Sadly the video doesn't render correctly the lag.

Malopieds commented 3 weeks ago

I didn't add this animation, but try to fix the old one. Could you tell me if it's better (given that this would be a debug version so, if you can build it it would be better)

Richard38907 commented 3 weeks ago

I haven't built a debug apk. What do I need?

Malopieds commented 3 weeks ago

If you want to test it as it will be on release you need androidStudio or build it by CLI. There is the debug version, but it's slower than release version, or you can't wait for a next release.

d4f5409d commented 3 weeks ago

And when I swipe up to see the queue, half of the queue UI is not appearing for the one second I swipe up then it reappears after the animation has ended and the screen stays without input again. It's like the queue was cut in half so we are able to see what's behind it (the currently selected tab in Innertune)

Screenshot_2024-08-23-11-17-28-96_56635af9b6ad4512d4187a5a49185a25.jpg

Malopieds commented 3 weeks ago

There is already an issue for the second thing you described.

I've already responded (and fixed) that. You're not using the latest debug version.

Richard38907 commented 3 weeks ago

Re-Ui lagging on 0.5.9

🎉The bug is only present on OnePlus devices (with snapdragon Soc) I haven't tested on other OnePlus specs (Mediatek Soc...) yet.

I tested now on a Google Pixel 7 and the UI is smooth like before. If other users encounter the problem with other brands/phone specs, please leave a feedback here 🙂.

YUG38 commented 3 weeks ago

Re-Ui lagging on 0.5.9

🎉The bug is only present on OnePlus devices (with snapdragon Soc) I haven't tested on other OnePlus specs (Mediatek Soc...) yet.

I tested now on a Google Pixel 7 and the UI is smooth like before. If other users encounter the problem with other brands/phone specs, please leave a feedback here 🙂.

@Malopieds the quoted text and https://github.com/z-huang/InnerTune/issues/1456 proves it ig and I have nord 300 if that helps

Malopieds commented 3 weeks ago

Yeah but there is no reason it bugs on some and other no. I don't know what I can do here :/

YUG38 commented 3 weeks ago

Ye idk, well we just gotta deal with it ig

Richard38907 commented 3 weeks ago

I cannot help you more. @YUG38 do you encounter the glitch too on your Nord N300? Screenshot_20240825-184708.png

It's a Mediatek soc.

YUG38 commented 3 weeks ago

@Richard38907 yes the app is "laggy" for me and idk what Mediatek soc is sorry

Richard38907 commented 3 weeks ago

Mediatek is a brand of phone's processor. OnePlus uses Qualcomm or Mediatek socs on their devices.

So the bug seems to occur on all OnePlus devices(Mtk/Snapdragon) but I don't know why. I know that Samsung uses Snapdragon SOCs but I don't know the real reason of that bug😕.

YUG38 commented 3 weeks ago

Oh ok I see, well we can't do anything ig, just gotta buy a new phone 😛 ( jk )

Richard38907 commented 3 weeks ago

OnePlus is a good brand. I don't plan to change now😅.

YUG38 commented 3 weeks ago

Did anyone check if the og repo app is lagging too or it's just this repo maybe that will make it a little easier to figure out what the issue is

Richard38907 commented 1 week ago

Tested on Samsung Galaxy A40. Worked perfectly but after the update, the glitch occurs.