Malopieds / InnerTune

A fork of InnerTune, a Material 3 YouTube Music client for Android
GNU General Public License v3.0
102 stars 4 forks source link

Add option to select songs in queue #38

Open Spaceshiprace opened 2 months ago

Spaceshiprace commented 2 months ago

Checklist

Feature description

I think it would be useful if there's option to select songs in the queue

Why do you want this feature?

sometimes i want to clear all the songs in queue so if there's the option to select the songs by clicking on "select all" it will be so useful

Additional information

Thanks for keep making this amazing app more better ❤️

Malopieds commented 2 months ago

Well if you want to clear the queue you can swipe down on the miniplayer, it will stop the song playing and clear all the queue.

Spaceshiprace commented 2 months ago

nah, cuz sometimes I want to remove a certain song only from the queue

SiddhantRakh commented 2 months ago

You can swipe right to clear a specific song in the queue.

Spaceshiprace commented 2 months ago

yeah i know but selecting songs is better to me. and I also didn't get what @Malopied means by swiping down on the miniplayer like why it should stop playing the song and then clear the queue like I just want to clear it without stopping the song, u know what I mean ?

Malopieds commented 2 months ago

yeah i know but selecting songs is better to me.

It's not possible for now, in addition the long press to select songs is already taken, and adding a button to select all is:

Malopieds commented 2 months ago

why it should stop playing the song and then clear the queue

Because it the current behaviour, and logic one.

Spaceshiprace commented 2 months ago

its just not making any sense to me but okey its not a problem, i just opened this issue to see if its possible not because a problem that needs to be fixed. Appreciate u for trying to make this app better anyway ❤️

Malopieds commented 2 months ago

I was thinking about adding this kind of behaviour to the long press. When you long press there is the menu and from the menu you would be able to select this songs, it will after allow multi select. It's the more effective way imo. What do you think ?

SiddhantRakh commented 2 months ago

Well how about implementing a check mark(tick) to select songs like Spotify: Screenshot_20240402-185849_InnerTune~2 Screenshot_20240402-190344_Spotify

Malopieds commented 2 months ago

Yep the spotify approach is definitely more usable. I'll look into it.

Spaceshiprace commented 2 months ago

Well how about implementing a check mark(tick) to select songs like Spotify:

really good idea, This is what I meant from the beginning cuz I saw it there on spotify and I wanted that option to be on innertune too

Malopieds commented 1 month ago

It is now implemented. Tell me if you find some bugs.

mostafaalagamy commented 1 month ago

It is now implemented. Tell me if you find some bugs.

After selecting the songs and changing my mind, if I want to deselect them, I must deselect them one by one. Adding a 'Deselect All' option is necessary.

Spaceshiprace commented 1 month ago

It is now implemented. Tell me if you find some bugs.

After selecting the songs and changing my mind, if I want to deselect them, I must deselect them one by one. Adding a 'Deselect All' option is necessary.

Strongly agree.

Spaceshiprace commented 1 month ago

but wait.. how i can select now ? is it available on that 0.5.7 version cuz i can't select the songs yet

Malopieds commented 1 month ago

After selecting the songs and changing my mind, if I want to deselect them, I must deselect them one by one. Adding a 'Deselect All' option is necessary.

Yes I agree with you.

but wait.. how i can select now ? is it available on that 0.5.7 version cuz i can't select the songs yet

No releases have been made yet, but you can try the latest debug version

Spaceshiprace commented 1 month ago

No releases have been made yet, but you can try the latest debug version

so yes I tried the debug version, and I got say its amazing, that feature works well from my experience the only issue is that it needs the "Deselect option" that was already mentioned, so yea it works without any bugs (for me)

Malopieds commented 1 month ago

Now implemented.

Spaceshiprace commented 1 month ago

also I noticed a thing, so now there's a deselect option so why isn't there an option to select all songs in the first place ?

SiddhantRakh commented 1 month ago

is that funny ?

Sorry bro it was by accident. I am using GitHub on Chrome as the app is trash so it might have been the reason for the emoji. I forgot I pressed it by accident as it takes 5 second for it to appear on Chrome.

Spaceshiprace commented 1 month ago

no prblm, matter fact I'm using it on a browser too 😅