Malopieds / InnerTune

A fork of InnerTune, a Material 3 YouTube Music client for Android
GNU General Public License v3.0
426 stars 21 forks source link

Random crash while playing songs in background #99

Open Malgotra opened 3 months ago

Malgotra commented 3 months ago

Checklist

Steps to reproduce the bug

Play any song in background.

Expected behavior

Play songs normally till user doesn't pause the song. No crash.

Actual behavior

After some time while playing songs app crashes without any logs.

Screenshots/Screen recordings

No response

Logs

Doesn't produce. App just closes.

InnerTune version

v0.5.6

Android version

Android 13

Additional information

Android 13. Motorola Moto G72

Malgotra commented 3 months ago

I found Same bug in main Innertune issue repository. https://github.com/z-huang/InnerTune/issues/1270

t3ddy-official commented 3 months ago

This is probably not a problem with InnerTune but rather just Android closing it down. Try disabling battery optimizations on it.

xdpirate commented 2 months ago

I'm experiencing this same issue on 0.5.7, but it also presents itself with the app in the foreground. It usually happens when the playback of a track ends and is proceeding to the next track in the queue.

It also seems to happen when the app is playing audio while the phone is locked, and then unlocked - the app will just crash with no error or any indications as to why. I've also experienced random crashes while downloading a playlist, especially combined with unlocking the phone to check download progress.

Battery optimizations are turned off (set to "Unrestricted" background use). Android 13, Samsung Galaxy Z Fold 3. Happens both in folded and closed states.

I haven't yet been able to reproduce on the latest debug build, but will report back once I've given it thorough enough testing.

Malopieds commented 2 months ago

will report back once I've given it thorough enough testing

Thanks, that could be really useful to see if that's something from InnerTune or the OS itself, some are just worse than other. I personally use grapheneOS so I've never seen this around but I'll keep looking for it!

kaneryu commented 2 months ago

+1 on @xdpirate 's description, that's exactly how it happens to me.

xdpirate commented 1 month ago

Here's a followup post after thorough testing and daily use for ~2 weeks.

The debug APK does not exhibit the same behaviour described in my previous post.

I used the GH Actions built APK for commit 8fd13b047e95b78ea844027c4fc6d940c1dec1ef.

https://github.com/Malopieds/InnerTune/actions/runs/9821011196

Everything described earlier seems to have been fixed at some point between the 0.5.7 release, and this commit :)

Malopieds commented 1 month ago

Everything described earlier seems to have been fixed at some point between the 0.5.7 release, and this commit :)

Wait so you mean this is not occurring anymore ?

xdpirate commented 1 month ago

@Malopieds Correct! The problem seems to have gone away by the commit I tested. For me, at least.

Malopieds commented 1 month ago

@Malopieds Correct! The problem seems to have gone away by the commit I tested. For me, at least.

Still now? Because in between I somehow reverted this commit x)

Is it the case for everyone ?

xdpirate commented 1 month ago

I have not tested any newer builds, but I can do that at some point soon.

Malopieds commented 1 month ago

I have not tested any newer builds, but I can do that at some point soon.

Should be starting from 7cf22d04a9eee8863a506a405ed64d0d9baba47e