Malorolam / LootBags

Other
21 stars 31 forks source link

Opener and Recycler Performance #163

Open Sir-Will opened 5 years ago

Sir-Will commented 5 years ago

LootBags-1.12.2-2.5.7

Malorolam commented 5 years ago

Hmm, I'll take a look and see if I can clean anything up to drop that down.

LXGaming commented 5 years ago

To add this issue every TileEntity (Loot Recycler, Bag Opener and Bag Storage) Calls sendToAll every tick

TileEntityOpener.java#L93 TileEntityRecycler.java#L72 TileEntityStorage.java#L61

capture Over 11k packets sent by LootBags in 1 second

xElementzx commented 5 years ago

lootbags network playercount lootbags te To add to @LXGaming this is on the same server, 5 players, including count of TE's and how large the packets are

Malorolam commented 5 years ago

Hmm okay, I think I have ideas on how to cut this down a lot. The packets themselves aren't large, there's just a ton of them. The bulk of this is the opener is sending unneeded packets when it's just sitting around waiting to work. I can't promise it'll be fixed quickly, time is limited for me right now.

Malorolam commented 5 years ago

Should be much improved in 2.5.8