Malorolam / LootBags

Other
21 stars 31 forks source link

1.7.10 changes to the configs don't apply #189

Open zpazz opened 5 years ago

zpazz commented 5 years ago

as stated above. i re-installed the mod+config and only swapped the text colors of the lootbags for testing reasons, and even that did not apply although the configs were properly saved.

zpazz commented 5 years ago

getting into detail: apparently the config does get saved. the command '$CRAFTEDFROM:$NULL' and drop customization applies. but any changes made to $ISSECRET $BAGTEXTCOLOR and others ... just have no effect. also adding a new custom lootbag won't show up in the NEI menu despite having set it to non-secret... i don't know where to start looking for what causes this.

Malorolam commented 5 years ago

1.7.10 is not under development anymore. If you post your bag config here I'll look at it.

zpazz commented 5 years ago

thanks for the quick reply. if i change lets say $BAGTEXTCOLOR to ''BLUE'' nothing will happen. same goes with the displayed texts (unopened/opened/shift) 11

Malorolam commented 5 years ago

Are you putting $BLUE or BLUE? The $ is important so the parser interprets commands correctly.

zpazz commented 5 years ago

yep. i also simply edited the bagtext slightly and nothing changed, while other changes did apply (craftedfrom/whitelist...)

Malorolam commented 5 years ago

That seems odd, as the $BLUE for the other bag clearly works. Did you try copy and pasting one of the existing lines in place? Also are you restarting the game each time?

zpazz commented 5 years ago

we're hosting at nitrado so i restarted, tested creating a new world etc. but the changes to the color / open-and shift text did not apply. i really double tested it. i did not test it standalone tho so it could be a conflict with one of the other mods - or those lines are client side only?

Malorolam commented 5 years ago

The colours are interacted with on client-side code, so even though it isn't formally client-side, it only does something on the client.

zpazz commented 5 years ago

so if i change the server config but not the config in my client files there won't be any changes to the colors/text? i mean getting the drops right was my main concern, if adjusting those cosmetics doesn't work thats not really a big deal.

Malorolam commented 5 years ago

Well, you should make sure that the configs are the same for the server and your players for all mods. Otherwise you encounter desync issues. Forge handles the configs generated by its system, but as the bag config is custom it doesn't apply there.

zpazz commented 5 years ago

okay i will take your advice haha. i'm only using your mod on our little private server tho - it perfectly adds to dungeon mods like chocolate/roguelike/infernalmobs etc. and we love it. thank you for replying so fast :)