Malorolam / LootBags

Other
21 stars 31 forks source link

Custom bag name not working #217

Open WiseHorror opened 4 years ago

WiseHorror commented 4 years ago

I created a custom bag with the unlocalized bag name lootbag_Bauble, which looks like this in the Lootbag_BagConfig.cfg:

$STARTBAG:lootbag_Bauble:15
    $ISSECRET:false
    $BAGCOLOR:20|20|20:255|255|255
    $BAGTEXTCOLOR:$WHITE
    $BAGTEXTUNOPENED:$WHITE:Should hold some sort of bauble.
    $BAGTEXTOPENED:$WHITE:How nice!
    $BAGTEXTSHIFT:$WHITE:I hope it's useful!
    $BAGVALUE:-1:-1
    $PASSIVESPAWNWEIGHT:1
    $PLAYERSPAWNWEIGHT:1
    $MOBSPAWNWEIGHT:1
    $BOSSSPAWNWEIGHT:1
    $USEGENERALLOOTSOURCES:false
    $MAXIMUMITEMS:1
    $MINIMUMITEMS:1
    $PREVENTITEMREPEATS:none
    $EXCLUDEENTITIES:false
    $BLACKLISTRECYCLER:true
    $STARTWHITELIST
        toolbelt:belt:0:1:1:1
        toolbelt:pouch:0:1:1:1
        xat:glowing_ingot:0:1:8:2
        xat:glowing_powder:0:1:16:5
        xat:glowing_gem:0:1:1:1
        xat:weightless_stone:0:1:1:1
        xat:inertia_null_stone:0:1:1:1
        xat:greater_inertia_stone:0:1:1:1
        xat:glow_ring:0:1:1:1
        xat:sea_stone:0:1:1:1
        xat:polarized_stone:0:1:1:1
        xat:dragons_eye:0:1:1:1
        xat:fairy_ring:0:1:1:1
        xat:dwarf_ring:0:1:1:1
        xat:wither_ring:0:1:1:1
        xat:poison_stone:0:1:1:1
        xat:ender_tiara:0:1:1:1
        xat:damage_shield:0:1:1:1
        baubles:ring:0:1:1:1
        bountifulbaubles:reforger:0:1:1:1
        bountifulbaubles:modifierbook:0:1:1:1
        bountifulbaubles:ringiron:0:1:1:1
        bountifulbaubles:trinketballoon:0:1:1:1
        bountifulbaubles:shieldcobalt:0:1:1:1
        bountifulbaubles:trinketobsidianskull:0:1:1:1
        bountifulbaubles:shieldobsidian:0:1:1:1
        bountifulbaubles:trinketmagiclenses:0:1:1:1
        bountifulbaubles:trinketapple:0:1:1:1
        bountifulbaubles:trinketvitamins:0:1:1:1
        bountifulbaubles:ringoverclocking:0:1:1:1
        bountifulbaubles:trinketshulkerheart:0:1:1:1
        bountifulbaubles:ringfreeaction:0:1:1:1
        bountifulbaubles:trinketbezoar:0:1:1:1
        bountifulbaubles:enderdragonscale:0:1:1:1
        bountifulbaubles:brokenblackdragonscale:0:1:1:1
        bountifulbaubles:trinketblackdragonscale:0:1:1:1
        bountifulbaubles:trinketmixeddragonscale:0:1:1:1
        bountifulbaubles:trinketankhcharm:0:1:1:1
        bountifulbaubles:shieldankh:0:1:1:1
        bountifulbaubles:ringflywheel:0:1:1:1
        bountifulbaubles:ringflywheeladvanced:0:1:1:1
        bountifulbaubles:magicmirror:0:1:1:1
        bountifulbaubles:potionrecall:0:1:1:1
        bountifulbaubles:wormholemirror:0:1:1:1
        bountifulbaubles:potionwormhole:0:1:1:1
        bountifulbaubles:trinketluckyhorseshoe:0:1:1:1
        bountifulbaubles:amuletsinempty:0:1:1:1
        bountifulbaubles:amuletsingluttony:0:1:1:1
        bountifulbaubles:crowngold:0:1:1:1
        bountifulbaubles:amuletsinpride:0:1:1:1
        bountifulbaubles:amuletsinwrath:0:1:1:1
        bountifulbaubles:trinketbrokenheart:0:1:1:1
        bountifulbaubles:amuletcross:0:1:1:1
        bountifulbaubles:phantomprism:0:1:1:1
        bountifulbaubles:disintegrationtablet:0:1:1:1
        bountifulbaubles:spectralsilt:0:1:1:1
        bountifulbaubles:flaregun:0:1:1:1
        potionfingers:ring:0:1:1:1
        qualitytools:emerald_ring:0:1:1:1
        qualitytools:emerald_amulet:0:1:1:1
    $ENDWHITELIST
$ENDBAG:lootbag_Bauble

and then made the resource pack with the en_US.lang file located in Lootbags lang.zip/assets/lootbags/lang/ which has this single line in it: name.lootbags_lootbag_Bauble.name=Bauble Lootbag

I also have the .mcmeta file in the root directory of Lootbags lang.zip which looks like this:

{
  "pack": {
    "pack_format": 3,
    "description": "Lootbag lang files for custom lootbags"
  }
}

However, in-game it still displays as "name.lootbags_lootbag_Bauble.name"

This is in 1.12.2

I looked at other issues people posted here, but none of them explain exactly what was wrong.

Galadriel1640 commented 4 years ago

I also ran into this issue, I believe this feature no longer works because if you take the same line and if you inject your own lang file into the mod jars asset it will work and rename the bag properly!

Maybe its a solution for you but I can't use it since you cant post edited jars on curse forge and I'm trying to add custom names for my mod pack