MalteKurz / VineCopulaCPP

A C++ library for vine copulas
http://maltekurz.github.io/VineCopulaMatlab/
MIT License
9 stars 6 forks source link

problems with asym_fgm #1

Closed cgroll closed 9 years ago

cgroll commented 9 years ago

I added the copula family in julia with the following formulas: http://cgroll.github.io/copula_theory/param_cops/Asym_FGM.html

Still, however, I get problems with the v-function, which returns values larger than 1. Maybe the cdf formula is without the -u1-u2 terms that we added?

I guess we should take a deeper look into this at Monday. Just wanted to let you know...

MalteKurz commented 9 years ago

Thanks for this issue. Indeed there have been used incorrect formulas for the CDF and the Vfun of the asymmetric FGM copula.

The copula is taken from the book of Nelsen (2006), p. 84 Example 3.16, where I set b=0.

I think the correct formulas are:

CDF: $$C(u{1},u{2})=u{1}u{2} + \theta u{1}u{2}(1 - u{1} - u{2} + u{1}u{2})u{2}(1 - u{1})$$ (Will be corrected in the PairCopulaCDF.cpp file)

PDF: $$c(u{1},u{2})=1- \theta (3u{1}^{2}-4u{1}+1)u{2}(3u{2}-2)$$ (Was correct in the PairCopulaPDF.cpp file)

HFUN: $$h(u{1},u{2}) = u{1} (1+\theta (1-u{1})^{2} u{2} (2-3u{2}))$$ (Was correct in the PairCopulaHfun.cpp file)

VFUN: $$v(u{1},u{2}) = u{2} (1+\theta u{2}(1-u{2})(3u{1}^2-4u_{1}+1))$$ (Will be corrected in the PairCopulaHfun.cpp file)