MamasBoyGitHub / universal-media-server

Automatically exported from code.google.com/p/universal-media-server
GNU General Public License v2.0
0 stars 0 forks source link

Kill old instance #2

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
http://code.google.com/p/universal-media-server/source/detail?r=39ac4fccbf361ecf
86f9fd6ca9de6b4331f5c9bb
I can't comment it so made it as a issue post(is it possible to comment the 
code also with others?)
What I remember when I played with it is that Windows reassigns free PID ID's 
sometimes (it differ for OS versions) so when you will try to terminate some 
old MEncoder process which already terminated and Windows started another 
process like IEXPLORE.EXE or EXPLORER,EXE etc. under same PID, you will see 
what SubJunk described. It will terminate whole desktop(explorer.exe and its 
mother) :-)
So fix should count also with the name of the process not only with ID so if 
PID 1356 should be terminated (MEncoder process), we should check if it is not 
eg. new svchost.exe process with "old" PID.
What do you think about it? It can be quite easily implemented.
ExSport

Original issue reported on code.google.com by ExSportCZ@gmail.com on 4 Jun 2012 at 12:59

GoogleCodeExporter commented 8 years ago
Yeah we could add the name there as well good idea.

Original comment by bajen.hasse on 5 Jun 2012 at 11:07

GoogleCodeExporter commented 8 years ago
Thanks, ExSport, good to see you here too :)

Original comment by subjunk on 9 Jun 2012 at 11:54

GoogleCodeExporter commented 8 years ago
Fixed and merged.

Original comment by bajen.hasse on 23 Jun 2012 at 6:32

GoogleCodeExporter commented 8 years ago

Original comment by bajen.hasse on 23 Jun 2012 at 6:32