Mamiglia / Reddit-Wallpaper

Tool to download and automatically set a random wallpaper from reddit
MIT License
43 stars 7 forks source link

[FEATURE] Notifications #26

Closed aTomicTurnip closed 2 years ago

aTomicTurnip commented 2 years ago

Would be nice if at any new walllpaper will appear a notification popup with all the main info (name, resolution, discussion link) and then fade out (like the old reddit wallpaper changer style, not the Windows standard notification)

Mamiglia commented 2 years ago

This is actually a very good idea, but why not windows standard notifications? It would ease some computation

aTomicTurnip commented 2 years ago

This is actually a very good idea, but why not windows standard notifications? It would ease some computation

Well, it's just personal taste, I don't really like Windows notifications. But if it's easier on your work, it's fine. Maybe later in the future you can develop a nicer notification system and allow users to choose between the two

Mamiglia commented 2 years ago

This feature has been implemented and will be inthe next release.

I did implement it with custum notifications (It turns out it's actually easier!), and I don't know where else I should use this notification system, or what to do when the notification is clicked.

At the current stage a notification is sent each time the wallpaper changes (can be turned off in settings), should I use this also for communicating a change failure?

Should I add an action when the notification is clicked? Like opening the post on Reddit? Current behaviour is that when clicked the notification goes away, and I honestly kinda like this behaviour because it looks less invasive

aTomicTurnip commented 2 years ago
Mamiglia commented 2 years ago

I will wait more feedbacks on this question, until then, since the current release supports this feature I'm gonna close this Issue