Man-fred / culfw.esp8266

CUL/CUN 433/868 MHz CC1101 Transceiver mit WLAN-Schnittstelle für FHEM - originally forked from svn2github/culfw (https://github.com/svn2github/culfw)
GNU General Public License v2.0
8 stars 5 forks source link

EEPROM: - allow wpakey with up to 40 chars #6

Closed Memphiz closed 2 years ago

Memphiz commented 3 years ago

My wpa key is longer then 20 characters and I struggled for a while with culfw.esp8266 until I realized the limit in the code.

I doubled it with this PR.

This is an incompatible change in regard to the EEPROM format. I was not sure if I should set the Version to 68 now or how to handle this properly.

Man-fred commented 3 years ago

Hi Memphis, you're right. I had copied EE_STR_LEN for ssid and key and this wasn't right. So this is a breaking update, the best is to change the length to the official maximum of ssid to 32 (31 + terminating \0) and key to 64.

VERSION shoud be left to 1.67, so this is the official last culfw-version. But VERSION_OTA must set to V01-67-01 for over-the-air updates.

I will test whether the AP starts after the update. Then this seems to be a good change.

Memphiz commented 3 years ago

Thx for the feedback - I will take care of it in the next couple of days I hope :)

Memphiz commented 3 years ago

I have updated the PR accordingly.

lolorc commented 3 years ago

I'm actually using it. looks ok. Thanks