search

ManOnDaMoon / omeka-s-module-RoleBasedNavigation

This module adds the ability to filter Omeka S sites' navigation links based on user roles.
GNU General Public License v3.0
3 stars 0 forks source link

[Bug] on Item Menu #1

Closed benyaminl closed 3 years ago

benyaminl commented 3 years ago

Bug on Item menu/Browse menu only. image

Fatal error: Uncaught Error: Call to a member function id() on null in 
/var/www/repo.sib.stts.edu/application/view/common/navigation-link-form/browse.phtml:13 Stack trace: 
#0 /var/www/repo.sib.stts.edu/vendor/laminas/laminas-view/src/Renderer/PhpRenderer.php(505): include() 
#1 /var/www/repo.sib.stts.edu/vendor/laminas/laminas-view/src/Helper/Partial.php(61): Laminas\View\Renderer\PhpRenderer->render(NULL, NULL) 
#2 [internal function]: Laminas\View\Helper\Partial->__invoke('common/navigati...', Array) 
#3 /var/www/repo.sib.stts.edu/vendor/laminas/laminas-view/src/Renderer/PhpRenderer.php(396): call_user_func_array(Object(Laminas\View\Helper\Partial), Array) 
#4 /var/www/repo.sib.stts.edu/modules/RoleBasedNavigation/view/role-based-navigation/navigation-link-form/browse.phtml(1): Laminas\View\Renderer\PhpRenderer->__call('partial', Array) 
#5 /var/www/repo.sib.stts.edu/vendor/laminas/laminas-view/src/Renderer/PhpRenderer.php(505): include('/var/www/repo.s...') 
#6 /var/www/repo.sib.stts.edu/vendor/laminas/laminas-view/src/View. in /var/www/repo.sib.stts.edu/application/view/common/navigation-link-form/browse.phtml on line 13
ManOnDaMoon commented 3 years ago

Hello and thanks for reporting the bug. I'll have a look at it.

ManOnDaMoon commented 3 years ago

It seems the application is unable to figure out which site it is currently editing.

Could you please provide the URL you are encountering the issue on? And also provide the version info for your Omeka S install and the RoleBasedNavigation module? One last thing to test is to disable all modules and only keep the RoleBasedNavigation to check if another issue is happening in another module.

benyaminl commented 3 years ago

it should be on https://repo.sib.stts.edu/admin/site/s/r/navigation _20210917_172802

version 1.0

ManOnDaMoon commented 3 years ago

Thanks. Would you be able to try the change introduced in 07c6186 ? This should fix the site not being passed as a parameter. This is an issue related to the Omeka S v3.1.0 update with the new query builder.

ManOnDaMoon commented 3 years ago

I've released the fix, please reopen the issue if you still encounter the same problem.

benyaminl commented 3 years ago

Hello, I just check this, and Update the module. it work as it's intended. Thank you very much 🙏🙏🙏

image