Bug/invalid error handler - Githubissues

ManPhamQuang / COSC2769-rmit

Further web programming - COSC2769

cosc-2769-rmit.vercel.app

MIT License

0 stars 0 forks source link

Bug/invalid error handler #115

Closed dangvuthang closed 3 years ago

dangvuthang commented 3 years ago

Changelog

Correctly handle google login error
Change response status code when receiving invalid JSON body
Remove error.name === "Error", which will always return true, thus mutating the error obj from prior handling

How to test

Start backend server

Run the following command:

CURL -X POST 'localhost:5000/api/v1/users/loginWithGoogle' \
-H 'Content-Type: application/json' \
-d '{"id": "eyjlk jsdlkjas dlpsajd sdj lsdpa jsdl kajsd pjsdal sadjasd"}'

See if the message correctly display

Note

This fix will remove invalid error message display on production

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/further-web/cosc-2769-rmit/FoED1KJjTbV9EeK9NYE8uXSu3sV4
✅ Preview: https://cosc-2769-rmit-git-bug-invalid-error-handler-further-web.vercel.app