3 - seed rhythm data on deploy/rebase - Man Sang Sin

ManSangSin / Rhythm-Code

https://starter-kit-al84.onrender.com/

ISC License

3 stars 7 forks source link

3 - seed rhythm data on deploy/rebase - Man Sang Sin #11

Closed ManSangSin closed 9 months ago

ManSangSin commented 9 months ago

Naming Rules

Name your PR like this: ISSUENUMBER-TITLE-YOURNAME

Description

modified docker file to include a seed file on first initialisation
created a seed file
defined new npm scripts to package.json to start/stop docker
added a readme with instructions to start/stop docker and info about seed file

Related to

Make sure you include the issue number with a hash sign # so Github can link this PR to the right issue, like this:

Fixes #3

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have carefully reviewed my own code
[ ] I have commented my code
[ ] I have updated any documentation

mferryRV commented 9 months ago

Hey @ManSangSin - in the future please do not merge PRs without approval. Any team with enough devs will use branch protection and a "four eyes process" meaning you and at least one other person need to look at code before it goes into production.

ManSangSin commented 9 months ago

Hey @ManSangSin - in the future please do not merge PRs without approval. Any team with enough devs will use branch protection and a "four eyes process" meaning you and at least one other person need to look at code before it goes into production.

Sorry, I wasn't sure how we were suppose to handle the PRs. I should've double checked before merging my code. It won't happen again

ManSangSin commented 9 months ago

Overall this does the job for local docker usage but I have made some notes that I would recommend implementing.

Also, please grant me maintainer rights to the repo or implement branch protection on main.

I've enabled branch protection on "main" but I can't seem to assign maintainer rights, it looks like I need to create an organisation first