Show description in modal for rhythm - Githubissues

ManSangSin / Rhythm-Code

https://starter-kit-al84.onrender.com/

ISC License

3 stars 7 forks source link

Show description in modal for rhythm #14

Open gregdyke opened 9 months ago

gregdyke commented 9 months ago

Story

As a website visitor
I Want to see the description of a rhythm in an unobtrusive way
So That I can get understanding that is not conveyed by the video

Acceptance Criteria

Given the rhythm has a description only
- When the modal for that rhythm opens
- Then the description is visible
Given the rhythm has a description and a video
- When the modal for that rhythm opens
- Then two tabs are visible, with the video tab selected
- And clicking the description tab shows the description
- And the tabs are unobtrusive (hover? tbd?) so that the solo video remains visually uncluttered

Implementation Notes

Obviously, needs data on the server to be added + in api calls, etc

Checklist:

[ ] I have defined the user story
[ ] I have defined some acceptance criteria
[ ] I have included any implementation notes
[ ] I have included all relevant links

mferryRV commented 9 months ago

Descriptions for the two data points (DC hand dancing and Rumba Guaguanco) would be helpful here.

gregdyke commented 9 months ago

https://www.youtube.com/watch?v=iLGuLEqtq7g

mferryRV commented 9 months ago

@gregdyke - how does this fit with #15 ? If a rhythm has Audio, Video, and a Description, how many tabs should there be?

If a rhythm has only Video or only a Description, should we display one tab or no tabs at all?