Show rhythm codes - Githubissues

ManSangSin / Rhythm-Code

https://starter-kit-al84.onrender.com/

ISC License

3 stars 7 forks source link

Show rhythm codes #16

Closed gregdyke closed 8 months ago

gregdyke commented 9 months ago

Story

As a website visitor
I Want to be able to see only the rhythm codes ("parent codes to a set of related rhythm, e.g. the Blues rhythm code is parent to Struttin', Ballroomin', Piedmont triple")
So That I'm not overwhelmed by the number of rhythms

Acceptance Criteria

Given a rhythm code exists
- When the map is shown
- Then the rhythm code is included
- And it looks visually distinct from the rhythms (dot with surrounding circle?)
Given a rhythm code exists with "child" rhythms
- When the rhythm code is clicked/selected
- Then a small pane is dropped down, listing the child rhythms
Given a rhythm code pane is shown
- When a rhythm is clicked
- Then the modal for that rhythm is shown

Implementation Notes

1. 2.

Checklist:

[ ] I have defined the user story
[ ] I have defined some acceptance criteria
[ ] I have included any implementation notes
[ ] I have included all relevant links

gregdyke commented 9 months ago

gregdyke commented 9 months ago

No longer doing this stretch goal as we are not showing the rhythms on the map for now.

~~Stretch goal: when a rhythm code is selected, highlight corresponding rhythms on the map~~

gregdyke commented 9 months ago

Concern: isolated rhythms would not belong to a rhythm code -> for now, no isolated rhythms How many rhythm codes shown at 1 time -> just one code can be selected at any one time

mferryRV commented 9 months ago

We need rhythm codes for DC hand dancing and Rumba Guaguanco in order to execute this effectively.

gregdyke commented 9 months ago

For now, I have for you:

Rhythm code: Rumba (location cuba/havana) Rhythms: (all same location - for now, distribute them in a grid around Havana and we will clarify with Deirdre) Rumba Columbiana https://www.youtube.com/watch?v=W4aMl4HpKIQ Rumba Guaguanco (already in db) Rumba Yambu https://www.youtube.com/watch?v=Mux8ibZWbrg Rumba Habanera https://www.youtube.com/watch?v=iLGuLEqtq7g

gregdyke commented 8 months ago

As added in https://github.com/ManSangSin/Rhythm-Code/issues/22, we will stop showing rhythms as dots on the map and only show rhythm codes -> this could be done in this ticket, or separately

mferryRV commented 8 months ago

This is a prerequisite for #44

We need to modify the data structure we use to focus on lists of Rhythm Codes rather than Rhythms. Currently /apis/rhythms returns a list of rhythms. We either need an API endpoint for a list of rhythm codes and their child rhythms OR the front-end needs to group rhythms by rhythm code.