Add :combined_output option

ManageIQ / awesome_spawn

AwesomeSpawn is a module that provides some useful features over Ruby's Kernel.spawn.

MIT License

9 stars 16 forks source link

Add :combined_output option #48

Closed NickLaMuro closed 4 years ago

NickLaMuro commented 4 years ago

Allows for combining STDOUT and STDERR streams into one stream, and makes the output available in both .output and .error (currently).

coveralls commented 4 years ago

Coverage remained the same at 100.0% when pulling 16b2869351880c15b900fddfc4cc7e436bcb150d on NickLaMuro:capture2e_option into aefe7f441cf310bee8d3d3f6dd62d1114db7c00c on ManageIQ:master.

Fryguy commented 4 years ago

@bdunne Can you also review?

NickLaMuro commented 4 years ago

@Fryguy I tentatively went with :shared_output for the key. You can discuss further if you feel strongly about another one. Left some other options in my other comment:

https://github.com/ManageIQ/awesome_spawn/pull/48#discussion_r370759998

UPDATE: This has been since changed to :combined_output per Brandon's request and rebased into the second commit.

miq-bot commented 4 years ago

Checked commits https://github.com/NickLaMuro/awesome_spawn/compare/90567f41605c4ab7102705a104940bcc873a6bd2~...16b2869351880c15b900fddfc4cc7e436bcb150d with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 2 files checked, 0 offenses detected Everything looks fine. :cake: